certainly caught me out before, do you think registration of generics could be made illegal?

# koin

[Alan Evans]

certainly caught me out before, do you think registration of generics could be made illegal?

[arnaud.giuliani]

sorry don’t understand 😕

[Alan Evans]

Suggestion: when attempting to register a generic type, it triggers a runtime exception.
Unless they have opted in to allow generics.

[arnaud.giuliani]

you mean, by trying t ooverride a type that already exists .... because declared a generic type?

[Alan Evans]

example:

single {
   emptyList<Int>()
}

Would fail at runtime.

[Alan Evans]

because List<Int> is generic.

[Alan Evans]

Nothing to do with overriding.

[arnaud.giuliani]

it won’t fail if you request it with a name:

single("myList") {
   emptyList<Int>()
}
get<List<Int>>(name = "myList")

[Alan Evans]

Are you saying it does fail if I don't provide a name?

[Alan Evans]

I'm stuck on 0.9.3 so I can't check!

[arnaud.giuliani]

won’t fail if you provide only one definition. But several list will have the same underlying type. That’s why we have to give a name.

[arnaud.giuliani]

stuck on 0.9.3? Why can’t upgrade?

[Alan Evans]

I wrote custom code to bridge to Java, and that doesn't work in later versions

[Alan Evans]

so now I'm waiting for dagger to be gone, then I won't need the custom code

[Alan Evans]

but right now we're stuck

[arnaud.giuliani]

404

[arnaud.giuliani]

😕

[Alan Evans]

sorry: https://github.com/blockchain/My-Wallet-V3-Android/blob/f6697c253eeae8707325fc4715860c48e4939265/common/network/src/main/kotlin/com/blockchain/koin/KoinDaggerModule.kt

[arnaud.giuliani]

The JavaKoinComponent class could help you perhaps

[arnaud.giuliani]

https://github.com/InsertKoinIO/koin/blob/master/koin-projects/koin-java/src/main/java/org/koin/java/KoinJavaComponent.kt

[Alan Evans]

thanks!