Hi there. I'm having some serious performance issu...
# koins
sloydev
10/26/2018, 11:17 AMHi there. I'm having some serious performance issues with Koin on Android. When I open a new activity the main thread freezes for about 7 seconds while resolving injections. Has anyone seen something similar?
sloydev
10/26/2018, 11:20 AMA bit more info. We migrated from Dagger to Koin. We have ~450 definitions total (number extracted from `BeanRegistry.definitions`'s size while debugging).
sloydev
10/26/2018, 11:20 AMLooking at systrace I can't see any specific big bottleneck. The long time seems to be the sum of a lot of recursive calls to InstanceRegistry.resolve() for all transitive dependencies. Nothing weird, but looking deeper every dependency is resolved in BeanRegistry.searchByClass(), which takes more than 10ms each. That's a lot!
sloydev
10/26/2018, 11:20 AMFunny weird facts:
- It only happens on physical devices, emulators seem unaffected.
- It only happens on debug buildtype, seems to work fine on release builds but I can't profile it to see what changed.
sloydev
10/26/2018, 11:21 AMsloydev
10/26/2018, 11:21 AMs
Sam
10/26/2018, 12:15 PMDoes it have something like Dagger's Lazy?
s
sloydev
10/26/2018, 12:55 PMIt does. I'm not using it in this example, but i do in other screens with similar result
a
arnaud.giuliani
10/26/2018, 1:14 PMEven around 450 definitions, resolution should not exceed ~1ms or seomthign like that
arnaud.giuliani
10/26/2018, 1:14 PMdo you create other stuffs?
arnaud.giuliani
10/26/2018, 1:20 PMWhat device do you use?
arnaud.giuliani
10/26/2018, 1:20 PMWhat version of Koin?
s
Sam
10/26/2018, 3:20 PMIf the object creation takes a while, you could inject an observable and offload the construction to a background thread via rxjava
s
sloydev
10/26/2018, 5:29 PMWe're using 1.0.1
sloydev
10/26/2018, 5:30 PMI tried it witg a Samsung Galaxy J5 and a OnePlus 5 with same results
sloydev
10/26/2018, 5:31 PMAnd we're not doing anything special in constructors or factories, just receiving other dependencies
c
cristiangm
10/30/2018, 4:14 PMIt seems what we saw matches with: https://github.com/InsertKoinIO/koin/pull/258
cristiangm
10/30/2018, 4:15 PMbut you said is done in 1.0.2 and it seems 1.0.2 still doing filter…
a
arnaud.giuliani
10/30/2018, 4:27 PMoptimization has been pushed out before reintegration / bad perfs behind 😞
s
sloydev
10/30/2018, 4:37 PMBTW I created a test project to reproduce our performance issues: https://github.com/Sloy/koin/blob/performance-test/koin-projects/androidperformancetest/src/main/java/sloydev/com/androidperformancetest/InjectionTest.kt
sloydev
10/30/2018, 4:38 PMA couple of results:
Copy code
=========|=====================
Device: | OnePlus OnePlus5 v8.1.0
---------|--------------------
Test: | Koin + Kotlin
Max: | 30,92 ms
Min: | 4,16 ms
Average: | 5,30 ms
---------|--------------------
Test: | Koin + Java
Max: | 9,15 ms
Min: | 4,57 ms
Average: | 5,00 ms
=========|=====================
=========|=====================
Device: | Huawei hwALE-H v6.0
---------|--------------------
Test: | Koin + Kotlin
Max: | 292,83 ms
Min: | 244,74 ms
Average: | 251,38 ms
---------|--------------------
Test: | Koin + Java
Max: | 413,13 ms
Min: | 383,13 ms
Average: | 386,13 ms
=========|=====================sloydev
10/30/2018, 4:39 PMWith tweaks similar to the ones in the PR we get
Copy code
=========|=====================
Device: | Huawei hwALE-H v6.0
---------|--------------------
Test: | Koin + Kotlin
Max: | 25,71 ms
Min: | 14,17 ms
Average: | 15,26 ms
---------|--------------------
Test: | Koin + Java
Max: | 155,88 ms
Min: | 145,08 ms
Average: | 146,83 ms
=========|=====================a
arnaud.giuliani
10/30/2018, 5:19 PM@sloydev ok thanks
arnaud.giuliani
10/30/2018, 5:19 PMWhy your Koin+Java part is so long?
s
sloydev
10/30/2018, 5:21 PMWe haven't figure that out yet. I plan on diggin on the cpu profiler to see what's going on. Seems weird that creating java classes take longer than creating kotlin ones, but who knows
3 Views