Hey :wave: , what are the tests I should run if I ...

# compiler

[andi]

Hey 👋 , what are the tests I should run if I want to verify that I didn't break anything with a fix for the irToJs part of the compiler?

[scaventz]

Sometimes I can find the associated test class by browsing git log, does this work for you?

[dmitriy.novozhilov]

Take a look at all tests in :js:js.tests module

[andi]

Thanks allot for the hints, I think I found the relevant part to add my test, see: https://github.com/JetBrains/kotlin/compare/master...awenger:kt-45738

I'm now only missing the part to regenerate all the ...BoxTestGenerated.java . Am I missing something obvious?

[dmitriy.novozhilov]

You can run ./gradlew generateTests or Generate Tests run configuration

[andi]

Thanks again. That worked like a charm. Afterwards all tests are green with :js:js.tests:test . However, if I run :compilerTest I get quite a few failing test ("JDK_15 is not set"). Is this a new requirement that was added? I also tried to install jdk 15 quickly and running the test again, but this seems to cause even more failing tests...
I'll give it another try tomorrow

[dmitriy.novozhilov]

Yep, we've added tests for JDk 15 few month ago and didn't update Readme. But if all your changes belong to js ir backend only then you can be sure that you didn't break anything in jvm tests

[andi]

Looks like something was wrong with my "quick" jdk 15 setup yesterday. Now :compilerTest ran fine on master. I still get a few failing tests like "CodeConformanceTest.testNoBadSubstringsInProjectCode" or "CompilerDaemonTest.testDaemonAutoshutdownOnIdle", but I assume these can be ignored. I'll :compilerTest my change now, and then open the PR

[dmitriy.novozhilov]

CodeConformanceTest.testNoBadSubstringsInProjectCode actually checks that code in repo satisfies our code style, so it's better to fix it (probably you've added @author doc or something similar)

[andi]

I ran :compilerTest against the master branch to verify that my overall setup is correct. So my changes were not in yet. The only files added/with a diff to master were libraries/kotlin.test/js/it/package-lock.json (was generated by some setup) and gradle/wrapper/gradle-wrapper.properties where I disabled distributionSha256Sum

[andi]

:compilerTest just finished for my branch and lead to the same failing tests I had with the master branch. Now I can also check what makes these tests fail:
• testNoBadSubstringsInProjectCode fails because of "@author" in ./js/js.tests/build/node_modules/mocha/mocha.js
• testThirdPartyCopyrights fails because of multiple files in js/js.tests/build/node_modules/...
So all regarding build artifacts that should be unrelated

[andi]

I opened the PR . Thanks allot for the help and hints Dmitriy 👍