Could any of the regular devs have a look at https://github.com/detekt/detekt/pull/2787 and tell me if I’m on the right track or if I am horribly wrong off road? Thanks 😄
g
gammax
06/12/2020, 7:35 PM
Hey Thomas, I’ve seen your PR (thanks for doing it btw). I’m just unsure there is the intention to let the detekt-gradle-plugin depend on the AGP 🤔
What you’re adding sounds like something that should be provided somehow, but my feeling is that the detekt gradle-plugin might not be the best place for it.
s
schalkms
06/12/2020, 8:48 PM
The detekt-gradle-plugin is the wrong place to do it. A detekt user with a web app doesn't want to depend on Android stuff.
Thanks for the contribution! I think this should be done in a separate module if the community wants to maintain this stuff.
d
dead.fish
06/15/2020, 10:35 AM
Yeah, thought as much. I wanted to have a proof-of-concept for it to see how far I can get. It’s working kind-of, but there are issues with Kotlin and Android-specific code generators that let Detekt spit out compilation errors (while still running through).
dead.fish
06/15/2020, 10:37 AM
Maybe it’s a good idea to split this out into a separate plugin, managed underneath the Detekt group, like