I setup detekt a while back and am trying to updat...

# detekt

[brent]

I setup detekt a while back and am trying to update from 1.0.0-RC146 to 1.4.0. Mostly working, but many of the rules simply aren't running. Looking through GH issues I see work was done around "type resolution" in v 1.1. Is this working on multi-module Android projects yet? I see this comment from back in October with no corresponding PRs since: https://github.com/arturbosch/detekt/issues/2036#issuecomment-544105669

[Artur Bosch]

Type resolution is used for the detekt tasks based on source sets e.g. detektMain or detektTest .
This brings a huge performance penalty. Testing detekt as a kotlin compiler plugin (https://github.com/detekt/detekt-compiler-plugin) lead to huge benefits for us where rules relying on type resolution will come to shine.

[brent]

Ok, so might not be related to Type Resolution then. I'm just running gw detekt on a module but some of the tasks seem to be silently not running.

I might be experiencing this same issue: https://github.com/arturbosch/detekt/issues/2038#issuecomment-573917395

[Artur Bosch]

Oh, I replied 11 minutes ago on that issue.

[brent]

Ok, cool. Good timing 🙂

Only custom tasks are allowed to override the classpath property.

I saw a bunch of references to creating this type of custom task with classpath. Including this https://github.com/arturbosch/detekt/issues/1967#issuecomment-538165203

Do you have a working example handy? It's referenced as a possible solution in a few places, but I haven't seen a working example posted anywhere yet.

[schalkms]

Please take a look at the following thread: https://github.com/arturbosch/detekt/issues/2038#issuecomment-573804409
There's an example project. You need to run detektMain in order to use rules that use type and symbol solving.

[brent]

@schalkms but detektMain isn't available on Android projects.

[brent]

https://github.com/arturbosch/detekt/issues/1967#issuecomment-537779807

[schalkms]

Sorry, I read over the fact that you are on Android.

[schalkms]

Android is still WIP as mentioned in the issue \2036.

[brent]

Yup... so back to a custom task then? Looking for a working example if you know of one. 🙏

[Artur Bosch]

dependencies {
    detekt(project(":detekt-cli"))
    detektPlugins(project(":detekt-formatting"))
}

val detektAll by tasks.registering(Detekt::class) {
    description = "Runs over whole code base without the starting overhead for each module."
    parallel = true
    buildUponDefaultConfig = true
    include("**/*.kt")
    exclude("**/resources/**")
    exclude("**/build/**")
    exclude("**/*.kts")
    // baseline.set(file("$rootDir/config/detekt/baseline.xml"))
    classpath.setFrom(project.configurations.getByName("detekt"))
    reports {
        xml.enabled = false
        html.enabled = false
        txt.enabled = false
    }
}

[Artur Bosch]

I had to exclude kts files due to some strange errors:

org.jetbrains.kotlin.util.KotlinFrontEndException: Front-end Internal error: Failed to analyze declaration Build_gradle
File being compiled at position: (1,42) in /build.gradle.kts
The root cause org.jetbrains.kotlin.resolve.lazy.NoDescriptorForDeclarationException was thrown at: org.jetbrains.kotlin.resolve.lazy.BasicAbsentDescriptorHandler.diagnoseDescriptorNotFound(AbsentDescriptorHandler.kt:18)

[brent]

Awesome. I think classpath.setFrom(project.configurations.getByName("detekt")) was the magic I was looking for. I'm out of time for today but I'll give this a shot tomorrow. Thanks!!

[Artur Bosch]

No problem, make sure to include the detektPlugins classpath too if you want to use formatting or other plugins

[schalkms]

Cool, I didn't even know about that.
@Artur Bosch We should persist this valuable information regarding type and symbol solving on the web site as well as https://github.com/arturbosch/detekt/issues/2038#issuecomment-574347664

[schalkms]

I'll open a new issue for that.
@brent thanks for bringing this to our attention, asking the right questions and for helping us to improve missing parts in detekt's documentation.

[brent]

👍. Thanks for all the help!!

[brent]

Just a quick update on this... I was never able to get this working on my multi-module android project. Tried in kts and gradle version of scripts, both in buildSrc and at project level. In both cases the tasks run & pass but never seems to find any kotlin source to run on.

[brent]

At this point I think I'm just going to stay on an old version of detekt and wait until Android-capable tasks are provided "out of the box".