https://kotlinlang.org logo
Channels
Powered by
#detekt
Title
# detekt
s

sanogueralorenzo

11/18/2019, 6:04 PM
Hello team, is it expected that even after autocorrecting something the task still fails? If after correcting the only issue (which has autoCorrect true) wouldn't it make sense to not have a build failure?
s

schalkms

11/18/2019, 7:40 PM
Does the following issue describe the problem that you experience?
s

sanogueralorenzo

11/21/2019, 5:29 PM
Hello @schalkms yeah exactly, last activity looks it is from Sep 6 🤔
Looks like it is still being discussed, right? I can't see a good reason to report it but if there is, having something like the suggested 
excludeCorrectable
in the .yaml file would be another solution too! (For the above case). The main usecase that I saw in my current company is that people run the 
./gradlew detektAll
task before pushing and they seem to be confused because it always fails even if all the issues were autoCorrectable (and were fixed during the top level detektAll task run).
oh looks like you pushed a commit on Aug 22 and there were already a few releases since then. Do you want to make a sample project so you can reproduce it? Or am I missing some flag? 🤔
s

schalkms

11/21/2019, 6:36 PM
I haven't got the time to push this fix further. Some tests as well as the exclusion in the BuildFailure report are missing. I hope that I have time to get back at this task soon.
Thanks for the feedback btw 🙂
4 Views
Powered by