Yeah, I’ll make sure to mention all the changes in...
# detektm
mauin
03/26/2018, 8:00 AMYeah, I’ll make sure to mention all the changes in the notes and also updated all documentation already in the branch
t
taso
03/26/2018, 8:01 AMDanke 😄
m
mauin
03/26/2018, 8:01 AMAnd once that’s merged I also might look into some 3rd party tools that incorporate detekt to possibly update them to the new API as well to save people some work 🙂
s
seb
03/26/2018, 10:02 AMWe currently are blocked on the Novoda Gradle plugin with supporting Detekt RC6-4 and up because you take out a public method we relied on to retrieve the current profile and thus its output — we’re holding out on updating right now given there’s this huge change upcoming, but we’ll be very happy to work with you on supporting 1.0 on release if we can coordinate a bit in advance, once your PR is shipped
a
Artur Bosch
03/27/2018, 5:01 AMwe surely will. If you still want to try to support rc6-4 you can take a look at the ProfileStorage object which has the missing method 🙂
s
seb
04/02/2018, 8:36 AMYeah we looked at it but we basically would need to compile Detekt into our plugin to be able to access it — some Groovy or Gradle dark magic failed us very badly otherwise
3 Views