<@U0B854PM2> yep currently the detekt does not car...
# detekta
Artur Bosch
02/07/2018, 12:20 PM@seb yep currently the detekt does not care about sourcesets and just parses from
project.projectDirt
toto
02/07/2018, 1:13 PM@Artur Bosch have you considered how this will impact the support for Android projects? the project model differs quite a bit because of how variants and sourcesets work.
toto
02/07/2018, 1:15 PMalso: would you be open to write the plugin in Groovy (to take advantage of its dynamic language features)?
a
Artur Bosch
02/07/2018, 1:50 PMI'm aware that android needs special treatment. The dsl is ready and was not hard, but the whole sourceSet and task creation is way above my knownledge. Just now I'm experimenting with the gradle classes: CodeQualityPlugin, CodeQualityExtension and SourceTask. Pmd etc are implemented that way. I don't gt the results I want and some sort of groovy magic is still missing to make it work ....
Artur Bosch
02/07/2018, 1:50 PMgroovy is ok for me, do you have experience writing plugins that are sourceset aware?
t
toto
02/07/2018, 1:51 PMI’m keen to help, as I have collected quite some knowledge writing few Gradle plugin in Groovy
toto
02/07/2018, 1:53 PMcouple of them are public in GH
- https://github.com/novoda/gradle-static-analysis-plugin
- https://github.com/novoda/gradle-build-properties-plugin
a
Artur Bosch
02/07/2018, 1:54 PMthanks I will take a look, I also found https://github.com/JLLeitschuh/ktlint-gradle, they are also generating tasks for each sourceset for kotlin 😮
t
toto
02/07/2018, 1:55 PMyeah, we’re planning to add KTlint support in our plugin soon
toto
02/07/2018, 1:55 PMand I gave a look at that, looks cool too
toto
02/07/2018, 1:56 PMthe thing I would avoid is making your plugin to depend on the Android Gradle Plugin
toto
02/07/2018, 1:56 PMthat’s where groovy can help a little
a
Artur Bosch
02/07/2018, 1:57 PMdoes the ktlint plugin depend on it?
t
toto
02/07/2018, 1:57 PMa
Artur Bosch
02/07/2018, 1:59 PMhm
Artur Bosch
02/07/2018, 2:01 PMthere is no way to extract android source sets without the dependency?
Artur Bosch
02/07/2018, 2:12 PMwell, if you have ideas how to extract all kotlin sourceSets based on my PR with the dsl changes, I would be grateful
t
toto
02/07/2018, 2:17 PMnot sure you can do that without having the AGP in your classpath, as you need to use the Android extension API
toto
02/07/2018, 2:17 PMgroovy is more flexible in that regard, as it tries to resolve properties dynamically, so as long as you guard your block against the fact you have applied the AGP or not you’re golden
a
Artur Bosch
02/09/2018, 10:50 PMhey, I merged the new dsl stuff into master. If you have ideas how to generate detektCheck tasks for the sourceset, that would be great!
2 Views