Any chance for Kotlin-1.4-M3 release?
# redux
r
Any chance for Kotlin-1.4-M3 release?
b
Curious about it too
r
Now we ask for 1.4.0-rc release
b
๐Ÿ˜„ Btw, is 0.5.3 resolving for someone on MPP project?
r
I'm using only
-js
artifacts.
b
nvm, was just gradle cache issues. It's compile is now angry about it being pre 1.4... ๐Ÿ˜•
Will raise a PR myself for rc later today
Few issues with dependencies still, will resolve them in a bit
@patjackson52 PR is ready, however snapshot publishing fails during signing with
Could not read PGP secret key
๐Ÿ‘€ 1
p
The github action does not have access to the secret because it is a fork of the repo. I should change the CI settings to only publish once merged into master or other desirable branches.
๐Ÿ‘ 1
b
Do changes otherwise look OK?
I've cleaned up build scripts a little as well to make use of new defaults from 1.4.0-rc (e.g. default stdlib dependencies)
p
Left some comments and changed the branch to
kotlin-1.4
(just branched off master)
๐Ÿ‘ 1
b
Done all I could for now. The rest is blocked by kotlin bugs
p
wow, just saw the build.gradle was converted to kts, interesting
b
Yeah, thought i could solve those browser() and nodejs() issues by converting buildscripts to kts, but sadly that didn;t help
Good news, after converting the last groovy buildscript to kotlin we now have browser() and nodejs() flavours working!
p
Awesome! Thanks!
0.5.4-SNAPSHOP should be live now
b
@Robert Jaros ^ is built with 1.4.0-rc
Please let us know if that works for you
r
is it ready?
can't find the artifacts
what repo should I use?
b
it's a snapshot version so probably not in maven central yet
r
but to compile kvision I need thunk as well
b
Ah damn it! Well i only need vanilla kredux for kvdom, but if you don't mind waiting I can raise a pr for thunks tomorrow evening
๐Ÿ‘ 1
๐Ÿ’ฏ 1
p
kotlin-1.4.0
branch created and snapshot build enabled on redux-kotlin-thunk https://github.com/reduxkotlin/redux-kotlin-thunk/tree/kotlin-1.4.0
b
Beat me to it! ๐Ÿ˜€
r
I see
0.5.3-SNAPSHOT
of thunk but it's still 1.3.72?
b
Must've been overriden by another change in the repo
@patjackson52 could you publish 1.4 artifacts as
0.5.3-k1.4.0-rc
to avoid overrides?
p
it will use the version in the build.gradle. I'm fine with either that ^^ name or 0.5.4-SNAPSHOT
snapshot will be appended to either
a
Is this already available?
b
Yes
Under snapshot
a
i keep trying:
"org.reduxkotlin:redux-kotlin-threadsafe:0.5.4-SNAPSHOP"
but nothing..
b
0.5.3-SNAPSHOT
Not 4
a
OH I see thank you! ๐Ÿ˜„
r
0.5.3-SNAPSHOT is still 1.3.72
b
Unless @patjackson52 released it under another
Oh
r
but i'm talking about thunk
redux-kotlin 0.5.4-SNAPHSOT is 1.4.0-rc
@Archie but you need to add
Copy code
maven { url = uri("<https://oss.sonatype.org/content/repositories/snapshots>") }
โค๏ธ 1
a
I see thank you ๐Ÿ˜„
p
@Big Chungus did you have luck with 0.5.4-SNAPSHOT? Iโ€™ve been testing 0.5.5 snapshot and having some gradle dependency errors with the metadata
b
Hmm odd, was resolving fine for me. @Robert Jaros how about you?
Although I've only tested with publishToMavrnLocal
r
It works for me with mavenlocal as well
p
ok. thanks. Actually 0.5.4-SNAPSHOT is working from maven for me. Iโ€™m having trouble with 0.5.5 and other tests publishications