<@UEU1NDQCD> i’ve found a pretty embarassing bug in arrow-integrations-jackson-module - seems like t...

# arrow-contributors

[mitch]

@Imran/Malic i’ve found a pretty embarassing bug in arrow-integrations-jackson-module - seems like that’s released for java 15 source compatibility. it works on maven but fails on gradle. 😭 https://github.com/arrow-kt/arrow-integrations/pull/93

[Javier]

Related to this:

https://kotlinlang.slack.com/archives/C19FD9681/p1652816267741679

[Javier]

we merged a PR with the last suggestion, but if it is not working, we should try the java/toolchain alternative here: https://github.com/arrow-kt/arrow-gradle-config

[Javier]

we would need to do withJava or something so in the KMP part, cc @Imran/Malic

[mitch]

@Javier what version was the gradle config which has the fix previously? i remember there was a renovate pr bump for arrow-gradle-config a while back. What I know is the latest alpha.15 of arrow-integrations-jackson was using 0.10.2 .

I needed to add java / toolchain to java 8 specifically in the corresponding module.

[mitch]

from my test locally adding that solves it. i tried that on various jdk, everything resolves to 8.

[mitch]

(disclaimer - i’m a gradle newbie)

[Javier]

Feels free to create a PR in arrow-gradle-config with that fix if you want 🙂

[Imran/Malic]

Arrow integrations has its CI with Java 15 so we need to change that

[mitch]

right..

[Imran/Malic]

AFAIK arrow-gradle doesnt need changes for that

[Javier]

@Imran/Malic that is good IMO, the problem is Kotlin has a bug which has been solved

[Javier]

They haven't provided a solution to those death properties yet

[Imran/Malic]

Do you know if it comes in 1.7 ? Or is already in 1.6.21?

[Javier]

we added the workaround mentioned in the issue, but as @mitch is mentioning, it looks like it is not working

[Imran/Malic]

Arrow gradle in arrow-integrations isnt on the alpha release we published this week

[Javier]

yeah, with 1.7 those properties don't exist (we have tried to add arrow gradle config to arrow inject and we got that crash)

[Javier]

ahhh

[Javier]

then maybe the fix is not there

[mitch]

ohh

[Javier]

I think we should avoid publishing alphas in arrow gradle config

[Javier]

to allow renovate pick the new release automatically in all repos, what do you think @Imran/Malic?

[mitch]

the alphas are really helpful

[mitch]

please keep them 😭

[Javier]

yeah @mitch, but I mean only for the arrow gradle config repo, rest will keep them 🙂

[Javier]

arrow-gradle-config is a repo which centralizes the entire Gradle configuration for all arrow organization repositories

[Imran/Malic]

I think we should avoid publishing alphas in arrow gradle config

i think both is fine I was publishing an alpha since we wanted to get the release out for arrow-endpoints and I wasn‘t sure if it works

[Javier]

ahh okay

[Imran/Malic]

But arrow-endpoints alpha was published successfully, so we can publish a new stable version

[Javier]

but it is sucessfully pubolished with Gradle metadata wrong, no?

[Javier]

using java 15

[Javier]

or you mean upgrading to the arrow gradle config alpha

[mitch]

looking at arrow-endpoints, it does use

arrowGradleConfig = "0.10.3-alpha.1"

and

- name: Set up Java
        uses: actions/setup-java@v3.1.0
        with:
          distribution: 'adopt'
          java-version: '15'

looks like there’s no java/toolchain mentions

[mitch]

let me try pulling that locally and see its metadata

[Javier]

yeah we used the another workaround

[Javier]

check the youtrack issue

[mitch]

oh this one? https://youtrack.jetbrains.com/issue/KT-45335/kotlinOptions-jvmTarget-conflicts-with-Gradle-variants#focus=Comments-27-4765781.0-0

configurations["runtimeElements"].attributes {
    attribute(TargetJvmVersion.TARGET_JVM_VERSION_ATTRIBUTE, 8)
}

or this other one? https://youtrack.jetbrains.com/issue/KT-52474/An-attribute-org-gradle-jvm-version-isn-t-set-correctly-while-up#focus=Comments-27-6102307.0-0

alt 1?

tasks.withType(JavaCompile::class.java) {
    targetCompatibility = "1.8"
    sourceCompatibility = "1.8"
}

or alt2? java toolchain

kotlin {
    jvmToolchain {
        languageVersion.set(JavaLanguageVersion.of(8))
    }
}

[mitch]

i’m pretty sure i tried suggestion 2, alt 1 - that did not work

[Javier]

@mitch the workaround was in 0.10.3-alpha.2

[Javier]

so endpoints is not using it

[mitch]

right..

[Javier]

and we don't know if it works yet

[Javier]

can you try with that version please?

[Javier]

if it doesn't work we will have to use your workaround with java toolchain

[mitch]

ah right i see your pr https://github.com/arrow-kt/arrow-gradle-config/pull/54/files

[mitch]

ok lemme try

[mitch]

hmm ok that didn’t seem too promising

[mitch]

trying gradle config alpha.2

[mitch]

using gradle config alpha.2

[mitch]

well this is interesting, the workaround “almost” works.. the api element was the wrong version but the runtime elements are of the right version!

[mitch]

@Javier fyi

[mitch]

i think we still need to use java / toolchain

[Javier]

I will create a PR in arrow gradle config but if you want feels free to create it :)

[mitch]

ok @Imran/Malic @Javier i’m going to check out for now, it’s almost midnight here. Will touch base again in the morning. 🤞 hopefully that’s enough data point. I’m quite convinced we need to use java / toolchain

[Javier]

okay, really thank you for your help ;)

[Imran/Malic]

Thanks @mitch for the insight :)

[mitch]

Oh right java / toolchain might not be needed i just realised we just need to set the apiElements as well

[Javier]

i think java toolchain looks cleaner than the current workaround

[Javier]

but not sure about his integration with kmp

[mitch]

i yolo-ed a PR to add apiElements https://github.com/arrow-kt/arrow-gradle-config/pull/58

[mitch]

what can possibly go wrong 😅

[Javier]

we can merge it and do an alpha release

[Javier]

if it doesn't work, we go for toolchain

[mitch]

🤞

[mitch]

ok that’s it for my battery, i’m checking out haha. good luck Javier, thanks again.

[Javier]

depending on the status of mavencentral servers, it should be available in 10-20 min

[Javier]

thank you indeed 😛

[mitch]

i’m gonna sleep for now and try in the morning while i bake my bread

[Javier]

which command are you running to check the variants version?

[mitch]

outgoingVariants

[mitch]

gradle :arrow-integrations-jackson-module:outgoingVariants

[Javier]

nice, thank you! see you 🙂

[Javier]

looks like it works @mitch

[Javier]

thank you 😄

[Javier]

message has been deleted

[mitch]

that’s awesome! is that alpha.3 ?

[mitch]

👌 awesome confirmed that I’ve also got the same 🙌 - i’ve updated the PR https://github.com/arrow-kt/arrow-integrations/pull/93

i’ve assigned you and Imran to review. @Imran/Malic @Javier

[Imran/Malic]

@mitch did it work?

[mitch]

Yep it does! 🙌

[Imran/Malic]

Awesome thanks @mitch for raising this up