Hey @mitch,
That’s absolutely okay!! Thanks for the awesome contributions. 😍
I pushed 2 small changes to your PR (fix KtLint and Binary Compat Validator), so we can still try to get it in before releasing later today 😉
I hope you don’t mind.
m
mitch
09/20/2021, 9:05 AM
ah! how did you do that?
s
simon.vergauwen
09/20/2021, 9:06 AM
Since I’m an admin on Arrow, I can push changes to PRs if the creator of the PR has enabled the checkbox that admins of the repo can.
m
mitch
09/20/2021, 9:06 AM
i was wondering on why that was failing. you might have something in the readme that i missed
😅 1
👌
thanks heaps @simon.vergauwen you’re a champ
❤️ 1
s
simon.vergauwen
09/20/2021, 9:07 AM
Yes, it’s a super recent additional that we still have to add in the contributors guidelines but instead of adding it there I hope to automate it after 1.0.0.
So contributors don’t have to worry about formatting, or checking in files for binary compatibility checks.