hey all! i figured that arrow doesn’t seem to supp...
# arrow-contributorsm
mitch
09/19/2021, 11:59 PMhey all! i figured that arrow doesn’t seem to support traverses for nullable? is it okay if i add it? I’ve opened a PR https://github.com/arrow-kt/arrow/pull/2519
s
simon.vergauwen
09/20/2021, 9:05 AMHey @mitch,
That’s absolutely okay!! Thanks for the awesome contributions. 😍
I pushed 2 small changes to your PR (fix KtLint and Binary Compat Validator), so we can still try to get it in before releasing later today 😉
I hope you don’t mind.
m
mitch
09/20/2021, 9:05 AMah! how did you do that?
s
simon.vergauwen
09/20/2021, 9:06 AMSince I’m an admin on Arrow, I can push changes to PRs if the creator of the PR has enabled the checkbox that admins of the repo can.
m
mitch
09/20/2021, 9:06 AMi was wondering on why that was failing. you might have something in the readme that i missed
😅 1
mitch
09/20/2021, 9:06 AM👌
mitch
09/20/2021, 9:06 AMthanks heaps @simon.vergauwen you’re a champ
❤️ 1
s
simon.vergauwen
09/20/2021, 9:07 AMYes, it’s a super recent additional that we still have to add in the contributors guidelines but instead of adding it there I hope to automate it after 1.0.0.
So contributors don’t have to worry about formatting, or checking in files for binary compatibility checks.
🙌 1
simon.vergauwen
09/20/2021, 4:48 PMIt made it into 1.0 🥳
simon.vergauwen
09/20/2021, 4:48 PMThanks for the cool contribution
simon.vergauwen
09/20/2021, 6:21 PM8 Views