https://kotlinlang.org logo
#arrow-contributors
Title
# arrow-contributors
s

stojan

09/26/2020, 10:47 AM
Ready for a review whenever someone has the time... thanks https://github.com/arrow-kt/arrow-core/pull/239
p

pablisco

09/26/2020, 10:49 AM
Have we decided to not have fold (as well as map, flstmap, etc) extensions for nullables values?
s

stojan

09/26/2020, 10:56 AM
Not sure about that.... I went trough the arrow-core API and added Nullable equivalents to the functions that have
Option
in their public API
p

pablisco

09/26/2020, 11:04 AM
I was just wondering as there is a
fold
converted to
?.let { } ?: run { }
I'll try to have a better look tonight
Good job replacing all those options 😁 must have been tidious
s

stojan

09/26/2020, 11:18 AM
yup,
fold
feels easier to type and read.... and the
?.let {} :? run {}
is the closes equivalent for a 1-1 replacement.....
thanks.... wasn't that bad 🙂
thanks for the review @pablisco
I applied some of the suggestions.... some I didn't 🙂 let me know if you feel strongly about the rest and I can do it 🙂
👍 1
p

pablisco

09/27/2020, 11:38 AM
Super! I'll have a look later, they were mostly trivial things :)
3 Views