anyone else has thoughts on this gt

Question

anyone else has thoughts on this gt <https github com arrow kt arrow integrations pull 26>

raulraja · Answer

This is a great Stojan

stojan · Answer

thanks Raul updated the PR description a review would be nice slightly smiling face

raulraja · Answer

approved

raulraja · Answer

still in draft mode

raulraja · Answer

this is as you know the right direction given our new emphasis in suspend

raulraja · Answer

so much needed and thanks again

raulraja · Answer

once you get it of draft mode let me know if its ready to merge

stojan · Answer

what is your take on this gt Figure out if there we should have 1 adapter factory shared with CallK or create a separate one for this especially since there is another PR adding different adapters slightly smiling face

stojan · Answer

then there is gt Problems gt There is a null check for the body meaning it errors on 204 No Content because the body is null in that case

raulraja · Answer

Since suspend sits on top of all effects as new kind F

raulraja · Answer

and retrofit calls are effects the one that uses Kind is no longer needed

raulraja · Answer

since suspend gt Either already encode the semantics and abilities to go to Rx and others but < simon vergauwen> may have a different opinion on this

raulraja · Answer

the issue is that this enforces Either so the other one should be deprecated or adapted to just suspend without Either

raulraja · Answer

the latter will be preferable for the time being IMO

stojan · Answer

the other also covers Rx Mono

stojan · Answer

suspend without Either is supported by Retrofit natively I m just building on top of it

raulraja · Answer

Does Reactor and Rx have bindings already for suspend

stojan · Answer

For Rx there is and additional first party adapter <https github com square retrofit tree master retrofit adapters rxjava|https github com square retrofit tree master retrofit adapters rxjava> And this has nothing to do with suspended

simon.vergauwen · Answer

gt Does Reactor and Rx have bindings already for suspend There are KotlinX integration bindings for Rx amp Reactor and Arrow Fx offers bindings for Rx Reactor as well

stojan · Answer

I guess I misread the question and also there is Coroutines to Reactive Streams helpers <https github com Kotlin kotlinx coroutines blob master reactive kotlinx coroutines reactive README md>