https://kotlinlang.org logo
#arrow-contributors
Title
# arrow-contributors
s

stojan

05/16/2020, 11:00 AM
anyone else has thoughts on this -> https://github.com/arrow-kt/arrow-integrations/pull/26
👍 1
r

raulraja

05/16/2020, 11:22 AM
This is a great Stojan
s

stojan

05/16/2020, 11:43 AM
thanks Raul.... updated the PR description, a review would be nice 🙂
r

raulraja

05/16/2020, 12:04 PM
approved
still in draft mode
this is as you know the right direction given our new emphasis in suspend
so much needed and thanks again
once you get it of draft mode let me know if its ready to merge
s

stojan

05/16/2020, 12:12 PM
what is your take on this -> Figure out if there we should have 1 adapter factory (shared with CallK) or create a separate one for this. especially since there is another PR adding different adapters 🙂
then there is:
Problems:
There is a null check for the body, meaning it errors on 204 (No Content) because the body is null in that case.
r

raulraja

05/16/2020, 12:20 PM
Since suspend sits on top of all effects as new kind F
and retrofit calls are effects, the one that uses Kind is no longer needed
since suspend -> Either already encode the semantics and abilities to go to Rx and others but @simon.vergauwen may have a different opinion on this
the issue is that this enforces Either so the other one should be deprecated or adapted to just suspend without Either
the latter will be preferable for the time being IMO
s

stojan

05/16/2020, 12:22 PM
the other also covers, Rx, Mono....
suspend without Either is supported by Retrofit natively, I'm just building on top of it
r

raulraja

05/16/2020, 12:49 PM
Does Reactor and Rx have bindings already for suspend?
s

stojan

05/16/2020, 12:56 PM
For Rx there is and additional first party adapter https://github.com/square/retrofit/tree/master/retrofit-adapters/rxjava And this has nothing to do with suspended
s

simon.vergauwen

05/16/2020, 4:33 PM
Does Reactor and Rx have bindings already for suspend?
There are KotlinX integration bindings for Rx & Reactor, and Arrow Fx offers bindings for Rx/Reactor as well.
s

stojan

05/16/2020, 4:35 PM
I guess I misread the question.... and also there is Coroutines to Reactive Streams helpers: https://github.com/Kotlin/kotlinx.coroutines/blob/master/reactive/kotlinx-coroutines-reactive/README.md
5 Views