anyone else has thoughts on this -&gt; <https://github.com/arrow-kt/arrow-integrations/pull/26>

# arrow-contributors

[stojan]

anyone else has thoughts on this -> https://github.com/arrow-kt/arrow-integrations/pull/26

[raulraja]

This is a great Stojan

[stojan]

thanks Raul.... updated the PR description, a review would be nice 🙂

[raulraja]

approved

[raulraja]

still in draft mode

[raulraja]

this is as you know the right direction given our new emphasis in suspend

[raulraja]

so much needed and thanks again

[raulraja]

once you get it of draft mode let me know if its ready to merge

[stojan]

what is your take on this -> Figure out if there we should have 1 adapter factory (shared with CallK) or create a separate one for this.

especially since there is another PR adding different adapters 🙂

[stojan]

then there is:

Problems:

There is a null check for the body, meaning it errors on 204 (No Content) because the body is null in that case.

[raulraja]

Since suspend sits on top of all effects as new kind F

[raulraja]

and retrofit calls are effects, the one that uses Kind is no longer needed

[raulraja]

since suspend -> Either already encode the semantics and abilities to go to Rx and others but @simon.vergauwen may have a different opinion on this

[raulraja]

the issue is that this enforces Either so the other one should be deprecated or adapted to just suspend without Either

[raulraja]

the latter will be preferable for the time being IMO

[stojan]

the other also covers, Rx, Mono....

[stojan]

suspend without Either is supported by Retrofit natively, I'm just building on top of it

[raulraja]

Does Reactor and Rx have bindings already for suspend?

[stojan]

For Rx there is and additional first party adapter https://github.com/square/retrofit/tree/master/retrofit-adapters/rxjava

And this has nothing to do with suspended

[simon.vergauwen]

Does Reactor and Rx have bindings already for suspend?

There are KotlinX integration bindings for Rx & Reactor, and Arrow Fx offers bindings for Rx/Reactor as well.

[stojan]

I guess I misread the question....

and also there is Coroutines to Reactive Streams helpers: https://github.com/Kotlin/kotlinx.coroutines/blob/master/reactive/kotlinx-coroutines-reactive/README.md