https://kotlinlang.org logo
Channels
100daysofcode
100daysofkotlin
100daysofkotlin-2021
advent-of-code
aem
ai
alexa
algeria
algolialibraries
amsterdam
android
android-architecture
android-databinding
android-studio
androidgithubprojects
androidthings
androidx
androidx-xprocessing
anime
anko
announcements
apollo-kotlin
appintro
arabic
argentina
arkenv
arksemdevteam
armenia
arrow
arrow-contributors
arrow-meta
ass
atlanta
atm17
atrium
austin
australia
austria
awesome-kotlin
ballast
bangladesh
barcelona
bayarea
bazel
beepiz-libraries
belgium
benchmarks
berlin
big-data
books
boston
brazil
brikk
budapest
build
build-tools
bulgaria
bydgoszcz
cambodia
canada
carrat
carrat-dev
carrat-feed
chicago
chile
china
chucker
cincinnati-user-group
cli
clikt
cloudfoundry
cn
cobalt
code-coverage
codeforces
codemash-precompiler
codereview
codingame
codingconventions
coimbatore
collaborations
colombia
colorado
communities
competitive-programming
competitivecoding
compiler
compose
compose-android
compose-desktop
compose-hiring
compose-ios
compose-mp
compose-ui-showcase
compose-wear
compose-web
confetti
connect-audit-events
corda
cork
coroutines
couchbase
coursera
croatia
cryptography
cscenter-course-2016
cucumber-bdd
cyprus
czech
dagger
data2viz
databinding
datascience
dckotlin
debugging
decompose
decouple
denmark
deprecated
detekt
detekt-hint
dev-core
dfw
docs-revamped
dokka
domain-driven-design
doodle
dsl
dublin
dutch
eap
eclipse
ecuador
edinburgh
education
effective-kotlin
effectivekotlin
emacs
embedded-kotlin
estatik
event21-community-content
events
exposed
failgood
fb-internal-demo
feed
firebase
flow
fluid-libraries
forkhandles
forum
fosdem
fp-in-kotlin
framework-elide
freenode
french
fritz2
fuchsia
functional
funktionale
gamedev
ge-kotlin
general-advice
georgia
geospatial
german-lang
getting-started
github-workflows-kt
glance
godot-kotlin
google-io
gradle
graphic
graphkool
graphql
graphql-kotlin
graviton-browser
greece
grpc
gsoc
gui
hackathons
hacktoberfest
hamburg
hamkrest
helios
helsinki
hexagon
hibernate
hikari-cp
hire-me
hiring
hongkong
hoplite
http4k
hungary
hyderabad
image-processing
india
indonesia
inkremental
intellij
intellij-plugins
intellij-tricks
internships
introduce-yourself
io
ios
iran
israel
istanbulcoders
italian
jackson-kotlin
jadx
japanese
jasync-sql
java-to-kotlin-refactoring
javadevelopers
javafx
javalin
javascript
jdbi
jhipster-kotlin
jobsworldwide
jpa
jshdq
juul-libraries
jvm-ir-backend-feedback
jxadapter
k2-early-adopters
kaal
kafka
kakao
kalasim
kapt
karachi
karg
karlsruhe
kash_shell
kaskade
kbuild
kdbc
kgen-doc-tools
kgraphql
kinta
klaxon
klock
kloudformation
kmdc
kmm-español
kmongo
knbt
knote
koalaql
koans
kobalt
kobweb
kodein
kodex
kohesive
koin
koin-dev
komapper
kondor-json
kong
kontent
kontributors
korau
korean
korge
korim
korio
korlibs
korte
kotest
kotest-contributors
kotless
kotlick
kotlin-asia
kotlin-beam
kotlin-by-example
kotlin-csv
kotlin-data-storage
kotlin-foundation
kotlin-fuel
kotlin-in-action
kotlin-inject
kotlin-latam
kotlin-logging
kotlin-multiplatform-contest
kotlin-mumbai
kotlin-native
kotlin-pakistan
kotlin-plugin
kotlin-pune
kotlin-roadmap
kotlin-samples
kotlin-sap
kotlin-serbia
kotlin-spark
kotlin-szeged
kotlin-website
kotlinacademy
kotlinbot
kotlinconf
kotlindl
kotlinforbeginners
kotlingforbeginners
kotlinlondon
kotlinmad
kotlinprogrammers
kotlinsu
kotlintest
kotlintest-devs
kotlintlv
kotlinultimatechallenge
kotlinx-datetime
kotlinx-files
kotlinx-html
kotrix
kotson
kovenant
kprompt
kraph
krawler
kroto-plus
ksp
ktcc
ktfmt
ktlint
ktor
ktp
kubed
kug-leads
kug-torino
kvision
kweb
lambdaworld_cadiz
lanark
language-evolution
language-proposals
latvia
leakcanary
leedskotlinusergroup
lets-have-fun
libgdx
libkgd
library-development
lincheck
linkeddata
lithuania
london
losangeles
lottie
love
lychee
macedonia
machinelearningbawas
madrid
malaysia
mathematics
meetkotlin
memes
meta
metro-detroit
mexico
miami
micronaut
minnesota
minutest
mirror
mockk
moko
moldova
monsterpuzzle
montreal
moonbean
morocco
motionlayout
mpapt
mu
multiplatform
mumbai
munich
mvikotlin
mvrx
myndocs-oauth2-server
naming
navigation-architecture-component
nepal
new-mexico
new-zealand
newname
nigeria
nodejs
norway
npm-publish
nyc
oceania
ohio-kotlin-users
oldenburg
oolong
opensource
orbit-mvi
osgi
otpisani
package-search
pakistan
panamá
pattern-matching
pbandk
pdx
peru
philippines
phoenix
pinoy
pocketgitclient
polish
popkorn
portugal
practical-functional-programming
proguard
prozis-android-backup
pyhsikal
python
python-contributors
quasar
random
re
react
reaktive
realm
realworldkotlin
reductor
reduks
redux
redux-kotlin
refactoring-to-kotlin
reflect
refreshversions
reports
result
rethink
revolver
rhein-main
rocksdb
romania
room
rpi-pico
rsocket
russian
russian_feed
russian-kotlinasfirst
rx
rxjava
san-diego
science
scotland
scrcast
scrimage
script
scripting
seattle
serialization
server
sg-user-group
singapore
skia-wasm-interop-temp
skrape-it
slovak
snake
sofl-user-group
southafrica
spacemacs
spain
spanish
speaking
spek
spin
splitties
spotify-mobius
spring
spring-security
squarelibraries
stackoverflow
stacks
stayhungrystayfoolish
stdlib
stlouis
strife-discord-lib
strikt
students
stuttgart
sudan
swagger-gradle-codegen
swarm
sweden
swing
swiss-user-group
switzerland
talking-kotlin
tallinn
tampa
teamcity
tegal
tempe
tensorflow
terminal
test
testing
testtestest
texas
tgbotapi
thailand
tornadofx
touchlab-tools
training
tricity-kotlin-user-group
trójmiasto
truth
tunisia
turkey
turkiye
twitter-feed
uae
udacityindia
uk
ukrainian
uniflow
unkonf
uruguay
utah
uuid
vancouver
vankotlin
vertx
videos
vienna
vietnam
vim
vkug
vuejs
web-mpp
webassembly
webrtc
wimix_sentry
wwdc
zircon
Powered by
Title
j

Jannis

12/20/2019, 4:26 PM
https://github.com/arrow-kt/arrow/pull/1868 This is ready for review, it fixes a lot of issues with
traverse
. Apart from
traverse
now being left to right for (all?) functors, this should not affect any existing code.
The order actually depends on the applicative instance, which in most if not all cases is left to right.
s

simon.vergauwen

12/20/2019, 5:32 PM
Ah this is great!
I read your comment about performance. I checked
Eval
and there are a couple of small improvements that can be made that I see immediately but nothing that would significantly speed it up.
Is it really that slow?
j

Jannis

12/20/2019, 5:45 PM
Not noticable for anything but collections that are beyond a certain size. Long sequences get the heaviest penalties,
generateSequence(0) { it + 1 }.take(10000).traverse(IO.applicative()) { IO { println(it) } }
takes a longer than my patience offers (upwards 5-10 min the last time I think, and my laptop is by no means slow). It does the first 1k and then gradually slows down.
traverse_
is equally slow, so I think it's on
foldRight
and likely on
Eval
. Do we even need it? We just need basic laziness not all the extras
Eval
brings, right? That is also the reason I chose
lazyAp(ff: () -> ...)
instead of
lazyAp(ff: Eval<...>)
. This might also be on sequences, but since even
traverse_
is not faster I think it's less likely. I'll retry with lists...
just retried it with
traverse_
, same thing, slowdown comes a bit later, but still not fast. It goes from 100s per refresh on the terminal to 10s to 1s
I take that back, it's probably not
traverse
.
generateSequence(0) { it + 1 }.take(10000).map { println(it) }
is also slowing down after the ~1.5k element mark. Just not as much as
traverse
. Fun
The list one is also plenty fast, so it's sequences, again. Why are these so slow... It's just a function with some carried state, this should not slow down ...
Sorry for the misleading text about slowness, should have tested it more/better, I've just mostly been working on sequences (with this pr and in the past propCheck) and it got frustrating to watch at some point 🙏
s

simon.vergauwen

12/20/2019, 6:00 PM
Ah… I’ve ran into similar issues with
Sequence
. That was also my first suspect, that’s why I jumped into the code.
There are a couple of tests for
Sequence
in Arrow-optics which are horribly slow compared to the other tests
Do we even need it? We just need basic laziness not all the extras
Eval
brings, right?
All the instances that can be rewritten without
Eval
probably should. If the laws hold then performance wins over Eval 😄
j

Jannis

12/20/2019, 6:09 PM
I just don't really get why the slow down occurs. https://github.com/JetBrains/kotlin/blob/deb416484c5128a6f4bc76c39a3d9878b38cec8c/libraries/stdlib/src/kotlin/collections/Sequences.kt#L538 has
generateSequence
as a stateful iterator which means at any point it' just current state + the same lambda that was passed before. This should be fast. It also slows down considerable without
take(10000)
so thats not it either.
Regarding eval, it makes for quite the ugly api, does it offer any benefit over
Function0
other than memoization?
s

simon.vergauwen

12/20/2019, 6:20 PM
Well, there is more than meets the eye in
Sequence
since it also relies on suspension IIRC
😟 1
Not sure if that somehow causes slow down, but there is most likely a lot more bytecode present than you think
👍 1
Regarding eval, it makes for quite the ugly api, does it offer any benefit over
Function0
other than memoization?
Not sure actual. Haven’t used either a lot.
j

Jannis

12/20/2019, 10:16 PM
I should do more testing before I jump to conclusions.
Tldr: sequences are fast. foldRight was the culprit. Stuff is fast now ^-^
I tried the generateSequence example again with fold and it worked fast. Then tried it again like I set up before and it is also fast. I probably ran something weird before. Sequences from kotlin are plenty fast. And the reason it is slowing down in arrow is the foldRight implementation which is copied from lists. The culprit is the recursive function which expects a sequence as it's argument and it gets the tail of a sequence by calling drop(1) which creates a new DroppingSequence every time. And because dropping sequences flatten themselves out the original sequence is kept alive with all it's elements and we basically iterate from the start for every element. This has an easy fix: Just use the iterator directly in foldRight.
s

simon.vergauwen

12/21/2019, 9:01 AM
Right, alright that makes sense. So it was Sequence but the issue was on our side
Exactly why our tests can use some more love!
💯 1