https://kotlinlang.org logo
#arrow-contributors
Title
# arrow-contributors
p

pakoito

07/08/2019, 3:13 PM
@Imran/Malic https://github.com/arrow-kt/arrow/pull/1509#issuecomment-509267111 Good job with FunctorFilter! Let’s do the others now 😄
👍 1
i

Imran/Malic

07/11/2019, 10:42 AM
@raulraja What is your opinion about the transfer from MonadFilter, TraverseFilter and MonadCombine ?
r

raulraja

07/11/2019, 10:44 AM
It's fine, thought we were doing FunctorFilter first but those need to be relocated to for AQL Fx integration
i

Imran/Malic

07/11/2019, 10:48 AM
so MonadFilter, TraverseFilter and MonadCombine should be in core right?
r

raulraja

07/11/2019, 10:58 AM
They can be in core but then we are leaving MTL to be teared appart like we did in Extras because that I can think MonadReader, MonadWriter etc… are not used at all and we never had questions or anything about those in the community
I also think they have little value given you can do DI with receivers an soon type classes which is much more performant than MonadReader etc.
i

Imran/Malic

07/11/2019, 11:07 AM
Agree. Maybe we can discuss this at a later point. @pakoito I can create an issue for that if you agree ?
p

pakoito

07/11/2019, 11:51 AM
We agreed splitting MTL this way on one of the meetings. Keep the RWS on a package, and XFilter/Combine and other non-RWS typeclasses back to core
maybe rename arrow-mtl to arrow-rws
(Read Write State)
r

raulraja

07/11/2019, 1:03 PM
@Imran/Malic I guess we can move those too now
We should probably wait on renaming until we see what's left behind
i

Imran/Malic

07/11/2019, 1:44 PM
I am on it 👌🏽
👍 1
4 Views