Try invalid JSON? <@U52KVPVB3>
# klaxonc
cedric
10/10/2018, 7:12 PMTry invalid JSON? @arve
s
Shawn
10/10/2018, 7:18 PMin my experience, invalid JSON yields a
KlaxonExceptionShawn
10/10/2018, 7:18 PMe.g.
com.beust.klaxon.KlaxonException: Expected "}", a value or ",", not 'EOF' at line 1a
arve
10/10/2018, 7:18 PMYeah
c
cedric
10/10/2018, 7:19 PM@Shawn I was actually thinking just that shortly after I wrote my incorrect answer 🙂
a
arve
10/10/2018, 7:20 PMthis is the test that i'm mutating to try and trigger a null result
Copy code
data class Thing(val foo: String)
assert(Klaxon().parse<Thing>("]") == null)arve
10/10/2018, 7:22 PMI'm trying to a) Understand why the return type of
parseT?Tk
keturn
10/10/2018, 7:27 PMyeah this came up a little while back and nobody had an answer for why that is nullable then either: https://kotlinlang.slack.com/archives/C90AVCDQU/p1535335916000200
k
karelpeeters
10/10/2018, 7:34 PMIt can't be
nullparseparseFromJsonObjectfromJsonObjectAnyT?a
arve
10/10/2018, 7:42 PMYeah, i just found that part. Is there a reason for this cast that I'm not seeing? Seems to me like it would be an improvement in ergonomics to drop the cast and update return types in the call chain to
Tc
cedric
10/10/2018, 7:43 PMDon’t bother, I’m fixing it right now
cedric
10/10/2018, 7:43 PMRemoving the nullable type
🙏 2
💯 1
cedric
10/10/2018, 7:46 PM Copy code
* @return a JsonObject or JsonArraycedric
10/10/2018, 7:49 PMDone.
cedric
10/10/2018, 7:50 PMGuess I could introduce a breaking change and return a
Either<JsonObject, JsonArray>k
karelpeeters
10/10/2018, 8:47 PMCan't you make both of them extend a sealed parent class and return that?
karelpeeters
10/10/2018, 8:47 PMThat shouldn't be a breaking change.
c
cedric
10/10/2018, 8:48 PMThat’s another option, yes
cedric
10/10/2018, 8:48 PMIt would be a breaking change for the JAckson parser plug-in, but well, it’s part of the repo so not really external
cedric
10/10/2018, 8:48 PMbut it would break other plug-ins (don’t think there is any at the moment though)
k
karelpeeters
10/10/2018, 8:50 PMNot familiar with that plugin (or the concept of plugins at all), how would it break?
c
cedric
10/10/2018, 8:51 PMIt’s recent: you can now plug your own parser to use instead of Klaxon’s. There is one using Jackson now, which is faster if you are parsing big documents
cedric
10/10/2018, 8:51 PMIt would break because it’s overriding
parse(): Any?cedric
10/10/2018, 8:51 PMThen again, I just broke it by removing nullability 🙂
cedric
10/10/2018, 8:52 PMI might as well create a base class
JsonObjectOrArrayk
karelpeeters
10/10/2018, 8:53 PMOh right there was a discussion about performance there, didn't know the result was called "plugins".
karelpeeters
10/10/2018, 8:53 PMThat name though 😶
c
cedric
10/10/2018, 8:54 PMWhich name don’t you like,
JsonObjectOrArraycedric
10/10/2018, 8:54 PMBaseJsons
Shawn
10/10/2018, 8:54 PMBaSONk
karelpeeters
10/10/2018, 8:59 PMJsonBasec
cedric
10/10/2018, 8:59 PMSounds good.
k
karelpeeters
10/10/2018, 8:59 PMThis definitely going into breaking territory but why are there functions that can return both? Is there ever a situation in which the caller doesn't know what it should be in advance?
c
cedric
10/10/2018, 8:59 PMWell I already have one 🙂
😢 1
cedric
10/10/2018, 9:00 PMIt can happen yes, but this is for the low level API
cedric
10/10/2018, 9:00 PMthe object binding API has
parse()parseArray()k
karelpeeters
10/10/2018, 9:00 PMHmm, feels weird having that information and throwing it away.
c
cedric
10/10/2018, 9:00 PMA downcast will still be necessary but narrowing the potential types to two is better than just having
Anycedric
10/10/2018, 9:01 PMall the object binding API does is cast it for you
cedric
10/10/2018, 9:02 PMWell,
JsonObjectJsonArrayJSonBasek
karelpeeters
10/10/2018, 9:02 PMsealed interfacec
cedric
10/10/2018, 9:03 PMThey’re in different compilation units but I could fix that too obviously
3 Views