https://kotlinlang.org logo
#mockk
Title
# mockk
c

christophsturm

06/30/2021, 9:44 AM
is it possible to merge or redo this branch: https://github.com/mockk/mockk/pull/612 and create a new mockk version, for easier compatibility to jdk 16?
bytebuddy should probably be bumped to 1.11.5
m

Mattia Tommasone

06/30/2021, 9:49 AM
i don’t think it can be merged because it has some build failures, it definitely should be investigated and possibly fixed
c

christophsturm

06/30/2021, 9:50 AM
yes it also has merge conflicts. i can make a new one
m

Mattia Tommasone

06/30/2021, 9:50 AM
that’d be awesome ❤️
c

christophsturm

06/30/2021, 11:09 AM
m

Mattia Tommasone

06/30/2021, 11:09 AM
wow, that was fast 😄
c

christophsturm

06/30/2021, 11:13 AM
🙂 had to disable one test that fails on jdk 16, maybe theres a way to conditionally disable it only on that jdk
people should not spy on collection classes anyway 🙂
😂 1
it seems android tests fail with jdk 16 too
I changed it to only update byte buddy and not run the tests on jdk16
because it does no harm and it fixes jdk16 for most people, so its good to get it merged
3 Views