does anyone have an idea how i can remove the dupl...

# strikt

[christophsturm]

does anyone have an idea how i can remove the duplication in this test: https://github.com/christophsturm/randolf/blob/b5c2eea6d5bd0da587220073ddb4496760b4e17a/src/test/kotlin/randolf/RandolfTest.kt#L84-L117

[dave08]

Derive SetDC and ListDC properties from a base class with Collection type, and use the same test with different input class type?

[christophsturm]

but they are data classes...

[christophsturm]

i could convert them to a class that takes collection before asserting. but it all feels wrong

[dave08]

Data classes can inherit from an interface, and all your tests are on collection size...

[dave08]

So you have a list of that interface with setdc and listdc in it with a forEach and run the tests inside it

[dave08]

Or make a custom assertion that takes a Collection of that interface, and do the assertion there

[christophsturm]

all great suggestions, thanks

[dave08]

Little note you might already be aware of, in your case it might be clearer to leave it as is, I only work harder to deduplicate when I have alot of tests to run that will benefit, it clarifies the tests' intention, or protects the tests from implementation details to make management easier... but sometimes abstractions can actually reduce test readability.

[christophsturm]

yeah, also very true