< louiscad> What do you think about adding overload for `vie kotlinlang #splitties

Channels

100daysofkotlin

100daysofkotlin-2021

algolialibraries

android-architecture

android-databinding

androidgithubprojects

androidx-xprocessing

arrow-contributors

beepiz-libraries

cincinnati-user-group

codemash-precompiler

codingconventions

competitive-programming

competitivecoding

compose-android

compose-desktop

compose-ui-showcase

connect-audit-events

cscenter-course-2016

domain-driven-design

effective-kotlin

effectivekotlin

embedded-kotlin

event21-community-content

fb-internal-demo

fluid-libraries

framework-elide

getting-started

github-workflows-kt

graviton-browser

image-processing

intellij-plugins

intellij-tricks

introduce-yourself

java-to-kotlin-refactoring

jhipster-kotlin

jvm-ir-backend-feedback

k2-early-adopters

kotest-contributors

kotlin-by-example

kotlin-data-storage

kotlin-foundation

kotlin-in-action

kotlin-multiplatform-contest

kotlin-pakistan

kotlinforbeginners

kotlingforbeginners

kotlinprogrammers

kotlintest-devs

kotlinultimatechallenge

kotlinx-datetime

lambdaworld_cadiz

language-evolution

language-proposals

leedskotlinusergroup

library-development

machinelearningbawas

myndocs-oauth2-server

navigation-architecture-component

ohio-kotlin-users

pattern-matching

pocketgitclient

practical-functional-programming

prozis-android-backup

python-contributors

realworldkotlin

refactoring-to-kotlin

refreshversions

russian-kotlinasfirst

skia-wasm-interop-temp

sofl-user-group

spring-security

squarelibraries

stayhungrystayfoolish

strife-discord-lib

swagger-gradle-codegen

swiss-user-group

tricity-kotlin-user-group

Title

i

ispbox

09/22/2019, 8:45 AM

@louiscad What do you think about adding overload for

view.dip()

to be able to deal with floating values where needed. Because without that you have to use your own helper or write extra code:

elevation = dip(4).toFloat()

Or dp(4) should be used? I'm just not sure about convention, but for me

dip()

fits better both for float and int.

l

louiscad

09/22/2019, 9:03 AM

@ispbox Yes,

dp

is for that.

i

ispbox

09/22/2019, 10:08 AM

OK, but what is the purpose for having both

dp

and

dip

? What`s wrong with overloading of

dip

?

You can argue that overloads are only possible for different parameter types (now they are both

Int

), but how to make elevation of 3.5f? 🙂 It should be float anyways.

l

louiscad

09/22/2019, 10:12 AM

@ispbox You can't overload based on return type.

i

ispbox

09/22/2019, 10:21 AM

This is what I was saying in my last comment. I would propose these two methods:

dip(Int): Int
dip(Float): Float

They could be easily overloaded. The only "problem" is that you have to write:

elevation = dip(4f)

But that is not a problem, it is a feature to be able to set floating point elevation, i.e.:

elevation = dip(3.5f)

l

louiscad

09/22/2019, 12:26 PM

Hum, I see, could be a great feature, I agree

Just checked the sources, and you convinced me! Do you want to submit a PR on the develop branch or should I do it myself?

i

ispbox

09/22/2019, 12:30 PM

Sorry, Louis, but please do that yourself, as it could influence some other code / public API. I don't know whether you should mark old API as deprecated or something similar (I mean

dp()

).

l

louiscad

09/22/2019, 9:25 PM

@ispbox Now I'm realizing I can equally use

dip

or

dp

. Please vote here: https://kotlinlang.slack.com/archives/CHJP9K00L/p1569187453013900

2 Views

#splitties Join Slack