Hi everyone! Correct me if this question should be...
# arrow-meta
n
Hi everyone! Correct me if this question should be posted on github instead. Are there updates on
typed quotes
PR? It's been around for a while now. Seems fully functional, but merge is blocked by conflicts.
r
Hi @Nikita Klimenko [JB] , cc @bloder. It’s been in hold also because FIR will change all those APIs potentially after 1.5.
But if you want to pick it up @Nikita Klimenko [JB] and make it ready for merge we can merge it in.
b
Hi! I'm having some problems that I can't focus my time, I've tried to merge but some tests started to fail, I need to resolve some personal things before continue coding, so sorry, if u wanna finish it, just merge and try to fix the tests, only missing that, so sorry again
r
no worries @bloder! hope all it’s good 🙏
👍 1
n
@bloder Thank you for bringing
typed quotes
up! I feared that it wouldn't be possible to access information that descriptors provides on quotes level.
@raulraja Hi! I'll look at tests, maybe could fix them. Talking about changes. I've read about quote's Transform.replace here https://kotlinlang.slack.com/archives/CJ699L62W/p1606300612089900?thread_ts=1606298499.088800&cid=CJ699L62W So if i'm to perform some sort of transformation, best option is to follow proofs plugin approach and operate on IR level?
r
@Nikita Klimenko [JB] it depends on what transformation you are trying to achieve. Do you have a small use case? Potentially IR may be better suited
n
@raulraja Something like this
debug(a, b, c)
->
debug(v("a", a), v("b", b), v("c", c))
r
yes, this would be much easier just in IR since you are basically just replacing a call for a different one
n
Ok, thank you ^^
👍 1
r
you could just intercept
irCall
or
irFunctionAccessExpression
and return the new IR tree whenever the call matches what you are looking after
The proof plugin inside the meta sources has several examples of rewriting IrCall and modifying things like its receiver etc.
r
Hi ! The pull request by @bloder has been merged after a previous change that fixed the checks 🙌
👏 1
♥️ 2