that work like charm, thank <@U4UGS5FC7>, <@U78L28...
# arrow-meta
t
that work like charm, thank @raulraja, @amanda.hinchman-dominguez and @Imran/Malic I don’t know why that
isNullable
is not available at least at
TypeReference
level. Prior to that i was using
text.contains("?")
that make me feels dirty
👍 3
i
feel free to contribute it 🙂 @raulraja should we keep this in KtUtils?
r
yes please
t
I will do a PR tomorrow
b
I think to provide a better api to our scopes maybe we should put a new prop in TypeReference scope and not in KtUtils:
Copy code
val isNullable: Boolean = value?.typeElement is KtNullableType
what do you guys think?
💯 1
Or better, we can work on KtTypeElement scope and put it there
👆 1
a
I think it's better if we do that
It's early to say what belongs in Utils, and that's because these properties are specific
It's easier to refactor later than it is to abstract now - we don't want to over DRY something when we're not sure what are parent elements
i
isNullable can be used everywhere not only in the QuoteSystem.
a
Right, not all properties or elements are meant to be nullable
There tends to be specific cases
If you haven't written out of a couple of these elements yourself, I'd recommend trying it out if you don't know how I mean
Not against the idea, but it's just a little early
Especially if it hasn't been tested!