https://kotlinlang.org logo
Join Slack
Powered by
pls help if you can!! <https://github.com/arrow-kt...
# arrow-meta
a
r
This is related to what we discussed earlier
It’s the Kastree converter missing a case for that node in the impl
a
the issue with trying to cast 
BinaryExpression
to 
CallExpression
?
r
Copy code
END quote.doAnalysis: [KtFile: Source.kt]
    START quote.doAnalysis: [KtFile: Source.kt]
    e: kotlin.NotImplementedError: An operation is not implemented: Unsupported VALUE_ARGUMENT
    	at arrow.meta.internal.kastree.ast.psi.ConverterKt.getAst(Converter.kt:838)
    	at arrow.meta.quotes.QuoteKt$replace$1.invoke(Quote.kt:298)
    	at arrow.meta.quotes.QuoteKt$replace$1.invoke(Quote.kt)
    	at arrow.meta.internal.kastree.ast.MutableVisitor$Companion$preVisit$1.preVisit(MutableVisitor.kt:344)
    	at arrow.meta.internal.kastree.ast.MutableVisitor$visit$$inlined$run$lambda$1.invoke(MutableVisitor.kt:10)
    	at arrow.meta.internal.kastree.ast.MutableVisitor$visit$$inlined$run$lambda$1.invoke(MutableVisitor.kt
from the failures on CI
a
oh yeah - as a separate issue, I created this: https://github.com/arrow-kt/arrow-meta/issues/260
That is something I'm happy to get back to
I'm just trying to see what easily passes now
r
ok
a
what we need to go back to implement
r
what do you need help with in the link you posted?
a
WhenConditionTest
and 
WhenEntryTest
is failing for the same exact reason - but I cannot evaluate the codegen comparison (I indicated the lines on the test on the branch 
arrow-meta-quotes-table
r
what is the stack trace?
a
CatchClauseTest
and 
ForExpressionTest
appear to be failing for the same reason with casting issues in Default element scope
This is the area failing for both when tests:
For 
WhenConditionTest
it goes to 
PsiFactory::createWhenCondition
-> 
PsiFactory::createWhenEntry
For 
WhenEntryTest
it goes to 
PsiFactory::createWhenEntry
r
Can you send the stack trace or share in the issue? the screenshot does not help see the root cause. The root cause may be in the stack trace
a
sure
r
The issue is that the text fed into the when entry may be malformed or cause this function to bail
a
right, at line 6
r
print out the text you are using before calling .whenEntry
to make sure that is actually something that would fit in
Copy code
"fun foo() { when(12) { $entryText } }"
a
sure thing
👍 1
entryText is 
x + 2 == 4  -> {}
That's from 
WhenConditionTest
r
what happens if you fix those extra whitespaces around the arrow?
I can also jump on a call and help you debug it if that helps
a
ahh that could be it - let me take a look for that
a call would definitely be helpful for some of the casting issues
r
To join the video meeting, click this link: https://meet.google.com/ysu-asyh-tbh Otherwise, to join by phone, dial +34 822 11 31 79 and enter this PIN: 829 139 674# To view more phone numbers, click this link: https://tel.meet/ysu-asyh-tbh?hs=5
3 Views
Open in Slack
PreviousNext
Powered by