https://kotlinlang.org logo
Join Slack
Powered by
We have to unshadow it on the way back for the ide...
# arrow-meta
r
We have to unshadow it on the way back for the idea plugin to be able to reuse code on the idea plugin from the compiler plugin
💯 1
a
@raulraja this definitely sounds like a monday task for me 😂 I will leave it for tomorrow (Monday), but let you know how it goes. I'm still preparing these talks
r
I think Rachel was working on this because it was an issue in testing and we are gonna discuss it tomorrow. We’ll keep you posted. Otherwise we also need a bunch of quotes for the different elements like @bloder’s PR if you want to help there. We still don’t have the list of quotes we are missing we could derive from the KtElement hierarchy and the scalameta quote table in their docs.
💯 1
a
@raulraja is there anything left needed for this PR as well? https://github.com/arrow-kt/arrow-meta/pulls
r
Hi @amanda.hinchman-dominguez do you mean this one?
a
^ yes, that one! Thank you
r
looks great, going to suggest a name change for the public function but other than that looks great. We still have no way to test these, once we do we can add tests to all of them
👍 1
a
But for sure, I'm really interested in hearing how things turn out Monday!
That might be something I do tomorrow then - start adding more of the Quote scope system because that's an easy win and I kind of know how to do it now while we wait on the ank and testing items
r
Just approved the PR asking for the name change, feel free to merge in once it’s all ready, thanks!
a
@raulraja I'll make those changes tonight, but @bloder and I are chatting about creating a strategy tomorrow and if he has time tonight, try one or two recommended bits on my end
r
sounds great
a
Thanks for sending him my way! We'll give you an update tomorrow on how we want to tackle this and see if there's a good way to track what we need to do
r
awesome, ping me if I can help in any way
a
In the meantime, @bloder and myself will try a couple totally different (seemingly random) Kt psi elements just in case there is a pattern we ought to be aware of when implementing the scopes for the quote system
So I've recommended 
KtElement
and 
KtLoopExpression
for now
For sure, we will want PR's for every one - maybe for the github issue we can just link it and format? idk
r
ok 
KtElement
is actually all of them because it’s the common supertype
a
whoops - ok, correction, we'll do another smaller one
r
I think looking at all subtypes of 
KtExpression
may yield more interesting quotes since that includes constants, etc.
👍 2
a
Most definitely. We want to do it eventually for sure
4 Views
Open in Slack
PreviousNext
Powered by