< Deactivated User> something wrong with division slightly s kotlinlang #korge

Channels

kotlin-foundation

compose-android

ohio-kotlin-users

kotlin-by-example

sofl-user-group

kotlin-multiplatform-contest

tricity-kotlin-user-group

kotlin-in-action

android-databinding

cincinnati-user-group

fluid-libraries

codemash-precompiler

kotlingforbeginners

jhipster-kotlin

prozis-android-backup

realworldkotlin

graviton-browser

spring-security

domain-driven-design

connect-audit-events

swiss-user-group

effectivekotlin

refactoring-to-kotlin

russian-kotlinasfirst

androidgithubprojects

introduce-yourself

pocketgitclient

effective-kotlin

algolialibraries

lambdaworld_cadiz

intellij-tricks

kotlin-pakistan

navigation-architecture-component

strife-discord-lib

machinelearningbawas

leedskotlinusergroup

stayhungrystayfoolish

kotest-contributors

practical-functional-programming

swagger-gradle-codegen

100daysofkotlin

kotlinultimatechallenge

pattern-matching

kotlinforbeginners

competitive-programming

compose-ui-showcase

competitivecoding

kotlin-data-storage

skia-wasm-interop-temp

java-to-kotlin-refactoring

event21-community-content

androidx-xprocessing

embedded-kotlin

fb-internal-demo

image-processing

myndocs-oauth2-server

kotlintest-devs

beepiz-libraries

kotlinprogrammers

cscenter-course-2016

k2-early-adopters

intellij-plugins

language-proposals

library-development

refreshversions

language-evolution

kotlinx-datetime

framework-elide

compose-desktop

jvm-ir-backend-feedback

android-architecture

100daysofkotlin-2021

github-workflows-kt

python-contributors

squarelibraries

arrow-contributors

codingconventions

getting-started

Title

y

y9san9

09/05/2021, 5:32 PM

@Deactivated User, something wrong with division 🙂

okay the problem was because of big precision (this is a standard in cryptoworld)

this also causes problems when using

times (*)

operator, since it under the hood twices the scale

d

Deactivated User

09/05/2021, 11:05 PM

can you provide an

assertEquals

that fails and create an issue at github? thanks in advanc

y

y9san9

09/06/2021, 8:50 AM

Okay, I will do that asap

ready, added my comment on the issue https://github.com/korlibs/kbignum/issues/6

👍 1

This is not related to division, it's kind of overflow of something, I don't know, but I really need this fix :(

d

Deactivated User

09/08/2021, 7:00 PM

what do you mean about it not being related to div? can you reproduce it with another operation?

I was going to check sometime this weekend, not sure if I will have time before, but if you have more info or other operations that fail, please provide them so I can check them along the div when I have some time to check

y

y9san9

09/08/2021, 7:01 PM

Sorry, my miss! The problem was that .bi does not take radix in my case. But it's an another issue, please make it to throw an exceptions if there is an unknown symbols...

and also the problem was that there is

0x

prefix

d

Deactivated User

09/08/2021, 7:02 PM

oh i see

well, we can support that I guess

y

y9san9

09/08/2021, 7:04 PM

Thanks to you a lot for your work! :kotlin-intensifies:

:kotlin-intensifies: 1

d

Deactivated User

09/08/2021, 7:17 PM

Regarding to the checks and prefix support: https://github.com/korlibs/korge-next/commit/fd43fdff8bf05dfe638971262d0911fdc75b003d

And also checked the division issue and fixed it here: https://github.com/korlibs/korge-next/commit/3068d8ef175ed879ea4d6849006e2c08b05edd40

y

y9san9

09/08/2021, 9:49 PM

Good job!

@Deactivated User when can you publish the new library version?

d

Deactivated User

09/14/2021, 2:11 PM

I didn't have plans for any soon release. Since I usually publish releases for all the libraries at once when there is significative work. But since it seems you need it, I have backported the changes to the kbignum repo, and triggered a build here: • https://github.com/korlibs/kbignum/releases/tag/v2.4.1.1 • https://github.com/korlibs/kbignum/actions/runs/1233972729

y

y9san9

09/15/2021, 4:23 AM

Thanks a lot again 😁

👍 1

#korge Join Slack