is there a contribution guide somewhere? like how ...
# compose-desktop
a
is there a contribution guide somewhere? like how to build compose on your machine for example? not sure where to start
a
There is the Jetpack Compose guide https://android.googlesource.com/platform/frameworks/support/+/refs/heads/androidx-main/CONTRIBUTING.md It should be the same (or very similar at least), as most of the compose-desktop stuff is done here https://github.com/JetBrains/androidx
a
thanks. ill check if the guidelines apply
i
Compose has two repos: 1. compose-jb, that contains samples, Gradle plugin, IDEA plugin, and additional components on top of Compose. Contribution to this repository is similar to contribution to the other GitHub repositories (just create a PR) 2. Compose itself - a fork of the
androidx
repo, where is Jetpack Compose is developed. We usually develop only platform targets there, and make bugfixes in common code. After sometime we upstream some changes to AOSP (to the original androidx repo). That leads to these requirements: • Contributor have to sign Google CLA • Contributor should agree that the author field of the commit can be lost (we can merge commits before upstreaming). We'll try to keep though, if possible. See example of the PR and what we usually ask. We have a document how to setup Compose repo, but we still doesn't have a document how to contribute. We plan to do that somewhen in the future. Bugfixes are always welcome, and we will try to review them as we find time. If you plan to contribute a feature, ask us before starting to make changes, especially if the change will be big (create an issue on GitHub, or here, in #compose-desktop)
https://android.googlesource.com/platform/frameworks/support/+/refs/heads/androidx-main/CONTRIBUTING.md
This guideline will be useful, if the fix is in common code (that is also used in Jetpack Compose for Android). In that case, make a fix in the original
androidx
repo, following this guide. Google usually review them, not JetBrains.
d
@Igor Demin how can i debug the compose compiler? i tried to • running gradle in debug mode • listening to remote jvm debug • adding
kotlin.compiler.execution.strategy=in-process
• placing println randomly (i had to use something more appropiate, i know) • attaching compose runtime sources jar in idea won't work • the only thing it (kinda) worked were error() calls i've cloned jb-compose, submodules and i've ran publishToMavenLocal scripts like in readme. any tips?