Hi I had a question regarding default value for `Modifier` a kotlinlang #compose

Channels

100daysofcode

100daysofkotlin

100daysofkotlin-2021

androidgithubprojects

cincinnati-user-group

competitive-programming

event21-community-content

java-to-kotlin-refactoring

jvm-ir-backend-feedback

kotlin-multiplatform-contest

kotlinultimatechallenge

myndocs-oauth2-server

naming

navigation-architecture-component

practical-functional-programming

proguard

prozis-android-backup

refactoring-to-kotlin

russian-kotlinasfirst

skia-wasm-interop-temp

stayhungrystayfoolish

swagger-gradle-codegen

tricity-kotlin-user-group

Title

wck

05/27/2022, 12:32 AM

Hi, I had a question regarding default value for

Modifier

as a parameter, apparently

fillMaxWidth

is ignored if passed like this.

@Composable
fun TextButton(
    modifier: Modifier = Modifier.fillMaxWidth(),

yeah, that’s the way to go, thanks.

tad

05/27/2022, 3:47 AM

Or just

modifier.fillMaxWidth()

This is perfectly idiomatic and is used throughout the Compose codebase.

Leland Richardson [G]

05/27/2022, 4:27 PM

yep. convention is to have the default expression just be

modifier: Modifier = Modifier

and then just start your modifier chain with that:

InternalTextButton(modifier = modifier.fillMaxWidth().etc(...)

note that the documents saying

the first modifier parameter must: …

are indicating what the convention is, not what is technically allowed/not allowed. what you wrote initially was perfectly valid kotlin, just not what you wanted 🙂

:google: 1

👍 1

dimsuz

06/01/2022, 10:42 AM

convention is to have the default expression just be
modifier: Modifier = Modifier

Oh, I guess I'll add it to the detekt-rules-compose as a new (togglable) rule. UPD: turns out there was already an issue-request for such a rule

4 Views

#compose Join Slack