Hey I think thats not the right approach: I want t...

# compose

[Jan]

Hey I think thats not the right approach: I want to have a map where the key is the "shop" and the value is a list of products. I currently use this for the map and this function for adding a value:

private val products: SnapshotStateMap<String, List<ShoppingItem>> = mutableStateMapOf()

fun add(shop: String, product: ShoppingItem) {
    val list = products.getOrDefault(shop, mutableListOf()).toMutableList()
    list.add(product)
    products[shop] = list
}

fun replace(shop: String, product: ShoppingItem) {
    val list = products.getOrDefault(shop, mutableListOf()).toMutableList()
    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) {
        list.replaceAll { if (it.id == product.id) product else it }
    }
    products[shop] = list
}

I mean adding works but the replace method doesn't wanna work and I don't think thats the right way

[hfhbd]

Don’t put a mutable collection (or any mutable class) inside a State. Instead adding a new product the inner list, you should update the entry of products with a readonly list

[Jan]

Like that?

products[shop] = list.toList()

[Jan]

or like that?

products[shop] = products.getOrDefault(shop, listOf()).plus(product)

[hfhbd]

Last one is a shortcut, and I would prefer it 🤷‍♂️

[Jan]

lemme try it

[Jan]

replace won't work as I said adding always worked

[Jan]

any idea for this?

[hfhbd]

Do you have a reproducer?

[Jan]

Not really, I click a button call my API and update the ui with the replace method

[Jan]

Nvm I'm dumb