Hey Everyone :smile:, I have a question about getting xml resources, `fun dimensionResource(@DimenRe...

# compose

[Alejandro Moya]

Hey Everyone 😄, I have a question about getting xml resources, fun dimensionResource(@DimenRes id: Int): Dp returns DP dimensions, but there’s no SP version of it, is there a way to return the SP xml dimensions?

[Adam Powell]

Is this a constant you share in both compose and in view layout xml?

[Alejandro Moya]

yes

[Alejandro Moya]

I’m working on migrating an existing app from xml layouts to compose and need to use the SP resources to access the font styles sizes

[mkrussel]

Not away to load as sp, but you can convert.

https://developer.android.com/reference/kotlin/androidx/compose/ui/unit/Density#(androidx.compose.ui.unit.Dp).toSp()

[Alejandro Moya]

I have a set of sizes for tablet and phone

[Alejandro Moya]

is that accurate?

[Alejandro Moya]

converting from DP to SP an SP xml resource?

[Adam Powell]

In the fullness of time you'll want to migrate off of using xml resources for size constants, but if you take a look at how the dimensionResource function reads android resources you should be able to write what you need here

[Alejandro Moya]

this fits into integrating compose on an existing app, the intention is to completely migrate to compose, but the app needs to work while migrating, there’s an existing codebase that won’t be migrated all at once since it’s way complicated to do

[mkrussel]

I don't know what dimensionResource does when loading an sp resources as dp. I was guessing it ignored the unit in the xml and just treated it as dp, but that is probably wrong.

[Alejandro Moya]

@Composable
@ReadOnlyComposable
fun dimensionResource(@DimenRes id: Int): Dp {
    val context = LocalContext.current
    val density = LocalDensity.current
    val pxValue = context.resources.getDimension(id)
    return Dp(pxValue / density.density)
}

[Alejandro Moya]

that’s the function

[mkrussel]

So I think conversion should work, but like @Adam Powell said it would be easy to implement an Sp version.

[mkrussel]

I don't think that is an error. getDimension loads as pixel value, and then dimensionResource converts to DP.

[Alejandro Moya]

yes, I deleted the comment as the resulting float is multiplied to return pixels

[Alejandro Moya]

I’ll have to create an SP version of it

[Alejandro Moya]

Thanks! 🙏

[Alejandro Moya]

https://issuetracker.google.com/issues/224658155