https://kotlinlang.org logo
#compose
Title
# compose
s

Siyamed

03/01/2022, 10:53 AM
FYI: includeFontPadding & Compose https://issuetracker.google.com/issues/171394808
😍 13
💥 2
🎉 8
c

Colton Idle

03/01/2022, 7:29 PM
This CL turns off includeFontPadding by default.
That's a bit surprising? It means that we should see some visual changes when updating right? Personally I think fontPadding should be off by default but im bias. I didn't think it'd actually ever be off by default.
s

Siyamed

03/01/2022, 8:20 PM
Yes as a result of that change it means that there will be visual changes. The change will be more visible for the custom fonts that had a bigger padding
We are thinking if we should provide a way to turn it back on (not as a continuous supported api but temporarily). However couldn't decide yet if we should and how we should .
c

Colton Idle

03/01/2022, 8:22 PM
Cool. I'm looking forward to it because that means all of my designs that were already coded up "to the design spec" will now just look better. I can dig it. Thanks
😅 1
👍 1
s

Siyamed

03/01/2022, 8:25 PM
Please let us know if we would breaking your apps if we didn't provide a temp api to turn it off.
c

Colton Idle

03/01/2022, 8:28 PM
Will do. Can't wait to give it a go in the next alpha!
c

Chris Sinco [G]

03/02/2022, 1:38 AM
@Siyamed are we planning any external details on this? Like it might be useful to blog about it to explain the before and after, especially since fontPadding is going to be off by default in the future.
s

Siyamed

03/02/2022, 5:48 PM
i'd love to, if the bandwidth allows
🙂 1