I have a utility function which `remember`s a call to `flowW

Question

I have a utility function which `remember`s a call to `flowWithLifecycle` and I m wondering if it s wise some code in thread

Chris Fillmore · Answer

``` Composable fun lt T gt Flow lt T gt lifecycleAware minActiveLifecycleState Lifecycle State = Lifecycle State STARTED Flow lt T gt val lifecycleOwner = LocalLifecycleOwner current return remember this lifecycleOwner flowWithLifecycle lifecycleOwner lifecycle minActiveLifecycleState ```

Chris Fillmore · Answer

I then have another function which calls this along with `collectAsState` ``` SuppressLint FlowOperatorInvokedInComposition Composable fun lt T gt Flow lt T gt lifecycleCollectAsState initial T minActiveLifecycleState Lifecycle State = Lifecycle State STARTED State lt T gt return lifecycleAware minActiveLifecycleState collectAsState initial ```

Chris Fillmore · Answer

However as you see I have to suppress `FlowOperatorInvokedInComposition` I m not sure if this poses a problem or not

Chris Fillmore · Answer

Further I have another one for `StateFlow`s which uses `value` as the initial value ``` SuppressLint StateFlowValueCalledInComposition Composable fun lt T gt StateFlow lt T gt lifecycleCollectAsState minActiveLifecycleState Lifecycle State = Lifecycle State STARTED State lt T gt return lifecycleCollectAsState value minActiveLifecycleState ```

Chris Fillmore · Answer

But as you can see I am now suppressing `StateFlowValueCalledInComposition` here

Chris Fillmore · Answer

I think perhaps wrongly that suppressing these errors is ok because I am `remember`ing the underlying Flow keyed with the upstream flow and the LifecycleOwner

Chris Fillmore · Answer

Is this wrong

Adam Powell · Answer

at a glance it looks like the lint warning is a bit overzealous cc < Louis Pullen Freilich G >

Adam Powell · Answer

looks fine to me with the exception that you re not using `minActiveLifecycleState` as a `remember` key if that changes a previously remembered flow won t

Louis Pullen-Freilich [G] · Answer

Yeah for anything similar to `collectAsState` in nature this is a false positive safe to ignore I don t think there s a way we can avoid warning here short of removing the lint check and I think basically every other case that it catches is worth catching

Louis Pullen-Freilich [G] · Answer

<https cs android com androidx platform frameworks support + androidx main compose runtime runtime src commonMain kotlin androidx compose runtime SnapshotFlow kt l=46|https cs android com androidx platform frameworks support + androidx main compose mmonMain kotlin androidx compose runtime SnapshotFlow kt l=46> It s suppressed on `collectAsState` too

Adam Powell · Answer

we could probably skip warning on flow extension functions that are marked ` Composable`

Louis Pullen-Freilich [G] · Answer

Yeah could work

Chris Fillmore · Answer

Thanks for responding And thanks for the advice Looks like I ll keep them suppressed for now and add `minActiveLifecycleState` as a key