I have a utility function which `remember`s a call...

# compose

[Chris Fillmore]

I have a utility function which `remember`s a call to flowWithLifecycle , and I’m wondering if it’s wise (some code in thread)

[Chris Fillmore]

@Composable
fun <T> Flow<T>.lifecycleAware(
  minActiveLifecycleState: Lifecycle.State = Lifecycle.State.STARTED,
): Flow<T> {
  val lifecycleOwner = LocalLifecycleOwner.current
  return remember(this, lifecycleOwner) {
    flowWithLifecycle(lifecycleOwner.lifecycle, minActiveLifecycleState)
  }
}

[Chris Fillmore]

I then have another function which calls this along with collectAsState

@SuppressLint("FlowOperatorInvokedInComposition")
@Composable
fun <T> Flow<T>.lifecycleCollectAsState(
  initial: T,
  minActiveLifecycleState: Lifecycle.State = Lifecycle.State.STARTED,
): State<T> {
  return lifecycleAware(minActiveLifecycleState).collectAsState(initial)
}

[Chris Fillmore]

However as you see I have to suppress FlowOperatorInvokedInComposition . I’m not sure if this poses a problem or not.

[Chris Fillmore]

Further, I have another one for `StateFlow`s which uses value as the initial value

@SuppressLint("StateFlowValueCalledInComposition")
@Composable
fun <T> StateFlow<T>.lifecycleCollectAsState(
  minActiveLifecycleState: Lifecycle.State = Lifecycle.State.STARTED,
): State<T> {
  return lifecycleCollectAsState(value, minActiveLifecycleState)
}

[Chris Fillmore]

But as you can see I am now suppressing StateFlowValueCalledInComposition here

[Chris Fillmore]

I think (perhaps wrongly) that suppressing these errors is ok, because I am `remember`ing the underlying Flow, keyed with the upstream flow and the LifecycleOwner.

[Chris Fillmore]

Is this wrong?

[Adam Powell]

at a glance it looks like the lint warning is a bit overzealous, cc @Louis Pullen-Freilich [G]

[Adam Powell]

looks fine to me with the exception that you're not using minActiveLifecycleState as a remember key; if that changes, a previously remembered flow won't.

[Louis Pullen-Freilich [G]]

Yeah, for anything similar to collectAsState in nature this is a false positive / safe to ignore, I don’t think there’s a way we can avoid warning here short of removing the lint check - and I think basically every other case that it catches is worth catching

[Louis Pullen-Freilich [G]]

https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/[…]mmonMain/kotlin/androidx/compose/runtime/SnapshotFlow.kt;l=46

It’s suppressed on collectAsState too

[Adam Powell]

we could probably skip warning on flow extension functions that are marked @Composable

[Louis Pullen-Freilich [G]]

Yeah, could work.

[Chris Fillmore]

Thanks for responding! And thanks for the advice. Looks like I’ll keep them suppressed for now and add minActiveLifecycleState as a key