Anyone have any opinions on passing a function thr...

# compose

[Afzal Najam]

Anyone have any opinions on passing a function through a deep hierarchy using CompositionLocals? Is it okay to do that?

[Tash]

curious what the use case is for that…a function doesn’t seem like something that should be handled with CompositionLocals…it sounds like trying to do dependency injection of sorts

[Adam Powell]

Yes, we could probably give better advice with more specifics about the use case. Without additional info I'd recommend no, avoid CompositionLocal and use parameters and/or lexical scoping of lambda capture instead.

[Adam Powell]

But that's not specific to what generic type the CompositionLocal might have 🙂

[Afzal Najam]

Thanks! The use-case is a library that shows a grid with image categories, and tapping on a category shows lots of images in that category. Tapping on the image invokes the function, which is sort of an action handler to close the enclosing (non-Compose) BottomSheet.

[Adam Powell]

Definitely avoid a CompositionLocal and just use normal parameters here

[Afzal Najam]

Thanks! Really appreciate the input! :)

[Adam Powell]

MyGrid(data, onImageClick = { imageInfo -> ... }, ...) Etc.

[Afzal Najam]

And just keep passing the click further down? It's like 5-10 levels down before the click function is relevant.

[Adam Powell]

it depends on the components involved. In practice the structure you described may end up looking like this:

MyGrid(dataSource) { item ->
  MyImage(item, onClick = { doStuffHere() })
}

at which point you're not explicitly passing an argument to anything but MyImage - none of the other intermediate layers know it exists