https://kotlinlang.org logo
Channels
100daysofcode
100daysofkotlin
100daysofkotlin-2021
advent-of-code
aem
ai
alexa
algeria
algolialibraries
amsterdam
android
android-architecture
android-databinding
android-studio
androidgithubprojects
androidthings
androidx
androidx-xprocessing
anime
anko
announcements
apollo-kotlin
appintro
arabic
argentina
arkenv
arksemdevteam
armenia
arrow
arrow-contributors
arrow-meta
ass
atlanta
atm17
atrium
austin
australia
austria
awesome-kotlin
ballast
bangladesh
barcelona
bayarea
bazel
beepiz-libraries
belgium
benchmarks
berlin
big-data
books
boston
brazil
brikk
budapest
build
build-tools
bulgaria
bydgoszcz
cambodia
canada
carrat
carrat-dev
carrat-feed
chicago
chile
china
chucker
cincinnati-user-group
cli
clikt
cloudfoundry
cn
cobalt
code-coverage
codeforces
codemash-precompiler
codereview
codingame
codingconventions
coimbatore
collaborations
colombia
colorado
communities
competitive-programming
competitivecoding
compiler
compose
compose-android
compose-desktop
compose-hiring
compose-ios
compose-mp
compose-ui-showcase
compose-wear
compose-web
confetti
connect-audit-events
corda
cork
coroutines
couchbase
coursera
croatia
cryptography
cscenter-course-2016
cucumber-bdd
cyprus
czech
dagger
data2viz
databinding
datascience
dckotlin
debugging
decompose
decouple
denmark
deprecated
detekt
detekt-hint
dev-core
dfw
docs-revamped
dokka
domain-driven-design
doodle
dsl
dublin
dutch
eap
eclipse
ecuador
edinburgh
education
effective-kotlin
effectivekotlin
emacs
embedded-kotlin
estatik
event21-community-content
events
exposed
failgood
fb-internal-demo
feed
firebase
flow
fluid-libraries
forkhandles
forum
fosdem
fp-in-kotlin
framework-elide
freenode
french
fritz2
fuchsia
functional
funktionale
gamedev
ge-kotlin
general-advice
georgia
geospatial
german-lang
getting-started
github-workflows-kt
glance
godot-kotlin
google-io
gradle
graphic
graphkool
graphql
graphql-kotlin
graviton-browser
greece
grpc
gsoc
gui
hackathons
hacktoberfest
hamburg
hamkrest
helios
helsinki
hexagon
hibernate
hikari-cp
hire-me
hiring
hongkong
hoplite
http4k
hungary
hyderabad
image-processing
india
indonesia
inkremental
intellij
intellij-plugins
intellij-tricks
internships
introduce-yourself
io
ios
iran
israel
istanbulcoders
italian
jackson-kotlin
jadx
japanese
jasync-sql
java-to-kotlin-refactoring
javadevelopers
javafx
javalin
javascript
jdbi
jhipster-kotlin
jobsworldwide
jpa
jshdq
juul-libraries
jvm-ir-backend-feedback
jxadapter
k2-early-adopters
kaal
kafka
kakao
kalasim
kapt
karachi
karg
karlsruhe
kash_shell
kaskade
kbuild
kdbc
kgen-doc-tools
kgraphql
kinta
klaxon
klock
kloudformation
kmdc
kmm-español
kmongo
knbt
knote
koalaql
koans
kobalt
kobweb
kodein
kodex
kohesive
koin
koin-dev
komapper
kondor-json
kong
kontent
kontributors
korau
korean
korge
korim
korio
korlibs
korte
kotest
kotest-contributors
kotless
kotlick
kotlin-asia
kotlin-beam
kotlin-by-example
kotlin-csv
kotlin-data-storage
kotlin-foundation
kotlin-fuel
kotlin-in-action
kotlin-inject
kotlin-latam
kotlin-logging
kotlin-multiplatform-contest
kotlin-mumbai
kotlin-native
kotlin-pakistan
kotlin-plugin
kotlin-pune
kotlin-roadmap
kotlin-samples
kotlin-sap
kotlin-serbia
kotlin-spark
kotlin-szeged
kotlin-website
kotlinacademy
kotlinbot
kotlinconf
kotlindl
kotlinforbeginners
kotlingforbeginners
kotlinlondon
kotlinmad
kotlinprogrammers
kotlinsu
kotlintest
kotlintest-devs
kotlintlv
kotlinultimatechallenge
kotlinx-datetime
kotlinx-files
kotlinx-html
kotrix
kotson
kovenant
kprompt
kraph
krawler
kroto-plus
ksp
ktcc
ktfmt
ktlint
ktor
ktp
kubed
kug-leads
kug-torino
kvision
kweb
lambdaworld_cadiz
lanark
language-evolution
language-proposals
latvia
leakcanary
leedskotlinusergroup
lets-have-fun
libgdx
libkgd
library-development
lincheck
linkeddata
lithuania
london
losangeles
lottie
love
lychee
macedonia
machinelearningbawas
madrid
malaysia
mathematics
meetkotlin
memes
meta
metro-detroit
mexico
miami
micronaut
minnesota
minutest
mirror
mockk
moko
moldova
monsterpuzzle
montreal
moonbean
morocco
motionlayout
mpapt
mu
multiplatform
mumbai
munich
mvikotlin
mvrx
myndocs-oauth2-server
naming
navigation-architecture-component
nepal
new-mexico
new-zealand
newname
nigeria
nodejs
norway
npm-publish
nyc
oceania
ohio-kotlin-users
oldenburg
oolong
opensource
orbit-mvi
osgi
otpisani
package-search
pakistan
panamá
pattern-matching
pbandk
pdx
peru
philippines
phoenix
pinoy
pocketgitclient
polish
popkorn
portugal
practical-functional-programming
proguard
prozis-android-backup
pyhsikal
python
python-contributors
quasar
random
re
react
reaktive
realm
realworldkotlin
reductor
reduks
redux
redux-kotlin
refactoring-to-kotlin
reflect
refreshversions
reports
result
rethink
revolver
rhein-main
rocksdb
romania
room
rpi-pico
rsocket
russian
russian_feed
russian-kotlinasfirst
rx
rxjava
san-diego
science
scotland
scrcast
scrimage
script
scripting
seattle
serialization
server
sg-user-group
singapore
skia-wasm-interop-temp
skrape-it
slovak
snake
sofl-user-group
southafrica
spacemacs
spain
spanish
speaking
spek
spin
splitties
spotify-mobius
spring
spring-security
squarelibraries
stackoverflow
stacks
stayhungrystayfoolish
stdlib
stlouis
strife-discord-lib
strikt
students
stuttgart
sudan
swagger-gradle-codegen
swarm
sweden
swing
swiss-user-group
switzerland
talking-kotlin
tallinn
tampa
teamcity
tegal
tempe
tensorflow
terminal
test
testing
testtestest
texas
tgbotapi
thailand
tornadofx
touchlab-tools
training
tricity-kotlin-user-group
trójmiasto
truth
tunisia
turkey
turkiye
twitter-feed
uae
udacityindia
uk
ukrainian
uniflow
unkonf
uruguay
utah
uuid
vancouver
vankotlin
vertx
videos
vienna
vietnam
vim
vkug
vuejs
web-mpp
webassembly
webrtc
wimix_sentry
wwdc
zircon
Powered by
Title
e

eygraber

07/26/2021, 5:24 PM
I'm about to get started on moving several large projects to compose, and I want to make sure that the architecture I planned on using would work well performance-wise. <tl;dr> I'm using a
Flow<SomeState>
with
collectAsState
instead of multiple
MutableState
and will rely on function skipping if the discrete fields in
SomeState
haven't changed (
SomeState
will be immutable). <\tl;dr> (longer description in thread)
I'm going for a variation on a flux architecture, where all of my UI state for a given screen will be stitched together (from 1+ sources) outside of the composable. The reason for this is that I've always had success with treating my architecture view as "dumb" and I'd like to keep it that way. It also helps enforce SRP and keeps things clean (business logic in a composable becomes a code smell that more easily sticks out in code reviews). UI events are passed to an outside layer, and they are one of the sources that the UI state is composed of. The plan for any given screen is to
collectAsState
from the UI state flow, and deconstruct it, passing the discrete state to multiple nested composables, to take advantage of the skipping aspect of compose (because it's unlikely that all state fields will mutate at the same time). My main concern is that I could run into performance issues, since this isn't really using the snapshot system. Is this a bad idea, and if not, what are some potential pitfalls to watch out for?
z

Zach Klippenstein (he/him) [MOD]

07/26/2021, 6:36 PM
I would think that’s fine - we’re doing the same. Just make sure your
SomeState
is deeply immutable, which I assume you were already doing. If your collectAsState is relatively high in your composable tree, then if something in the leaf of your state tree changes you’ll be recomposing a little more than if everything were mutable states, but compose should still mostly only recompose the path down the tree that leads to what actually changed, and I’m guessing most of those composables would be simpler layout definitions and stuff that won’t be that expensive.
I said that’s what we’re doing - we have done it with classic views and it’s been mostly fine. Compose should be even better. But we don’t have concrete benchmarking data so I can’t say for absolute sure. But Compose is much better at skipping than Android views (and requiring feature devs to implement their own skipping), so I can’t imagine compose would be worse.
e

eygraber

07/26/2021, 6:52 PM
Good to hear, thanks! The plan is to be at or near the highest point in the tree and to have deeply immutable state. We were waiting for something like https://github.com/lyft/domic to do this with the View system, but I'm guessing that never came to be because of Compose.
Just re-read your second message. To clarify, you've been doing this with View, but haven't done it yet with Compose?
z

Zach Klippenstein (he/him) [MOD]

07/26/2021, 7:56 PM
Correct. We’ve done some preliminary tests with compose, but aren’t using compose in production in anger yet so we don’t have any real-world data
Also I think this article discusses this stuff a bit
e

eygraber

07/26/2021, 8:17 PM
I'm actually asking my question because of that article 😅 Someone posted it on Reddit, and there was a comment saying that @Adam Powell didn't like
collectAsState
but I can't find it now (maybe after clarification the comment was deleted?)
a

Adam Powell

07/26/2021, 8:48 PM
it was specifically about the
initial = MovieDetailState()
in the
collectAsState
call - better to use a constant than construct a new default/empty one every recomposition just to pass it as an initial value that will be ignored after the first time 🙂
e

eygraber

07/26/2021, 10:33 PM
Ah interesting. I spent a nice amount of time in my architecture to address that issue 😂
n

Nathan Castlehow

07/27/2021, 1:27 AM
This is what we do for the most part (fitness app launching soon). We combine the data into a state object using a flow combine (our repositories return flows). The bit that gets weird is when we need to maintain some local state / operate on local state / access state from the flow inside of our view model. We mostly patched this together using snapshot flows / onEach when we needed to get state into the view model but I’m still not 100% happy. Always open to others thoughts on this one 🙂
e

eygraber

07/27/2021, 4:11 AM
I had some similar issues with accessing the state outside of the composable and dealt with that by maintaining a "copy" of the Flow in a StateFlow (this library is under heavy internal development so a lot of the extra stuff in this file is gone now - https://github.com/eygraber/cure/blob/a74f72e988dd3f60bd506940dd9b961b438cdd26/core/src/commonMain/kotlin/com/eygraber/cure/RenderNode.kt#L25 ). A RenderNode is the glue class in our architecture (like a very simple fragment). It probably doesn't translate well into other frameworks, but this is one way we're currently dealing with it.