Should I name a composable function that returns values thro

Question

Should I name a composable function that returns values through out parameters with a uppercase or lowercase name I have a function like so ```fun updatePreconditions activity Activity playServicesPreconditionMetState MutableState lt Boolean gt settingsPreconditionMetState MutableState lt Boolean gt Unit``` It returns by assigning to the states which I think is cleaner in this case than having generic callbacks Android Studio tells me I should write it `UpdatePreconditions` but I d assume something named like that affected the visible ui

Adam Powell · Answer

the naming convention is one of declarative entities in this case you re declaring the presence of a kind of actor Something like `PreconditionUpdater` might be appropriate

Adam Powell · Answer

I would also give the state of this thing its own type rather than accepting several generic `MutableState lt T gt ` objects it s kind of like how in most cases it s a bit janky to declare functions that accept or return `Pair lt X Y gt ` yes it technically works but it doesn t really carry a useful semantic meaning

Adam Powell · Answer

alternatively yes use callbacks to pass new data back up

Adam Powell · Answer

but depending on the nature of the preconditions themselves and how they change updating state may be more semantically appropriate

Daniel · Answer

Thanks that s really helpful I like the idea of thinking of it as an actor I think I ll split it up into two composables instead of making a type because the preconditions are logically separate and don t consitutue all the preconditions of the caller

Adam Powell · Answer

Something else to keep in mind is to avoid backwards writes during composition itself If your update function here is mutating state directly while composition is running as opposed to in Effects or similar callbacks after composition completes you can get into trouble if you have code reading those same state values earlier in the composition

Adam Powell · Answer

Composition doesn t backtrack

Adam Powell · Answer

This may be a reason to have this function behave more like updateTransition and return something read only instead since that kind of shape precludes the possibility of backwards writes without really going out of your way

Adam Powell · Answer

Ideally you should avoid writing this state while composition is executing anyway