A modern programming language that makes developers happier.

kotlinlang

Screen Shot 2021-04-21 at 4.09.50 PM.png

Why doesn't a disabled button have it's icon automatically tinted too? Code in :thread:

```Button(onClick = {}, enabled = false) {
                Text("Button is: Disabled")
                Icon(
                    imageVector = Icons.Filled.AccountBox,
                    contentDescription = null,
                    tint = MaterialTheme.colors.onPrimary,
                )
            }```

It may be because you are setting tint on the `Icon` which is likely overriding the `CompositionLocalProvider` settings on all content in the Button

Since I think `contentColor` is used for the children of Button in their respective color parameters.

What are your expectations for the tint of the icon?

Screen Shot 2021-04-21 at 4.33.45 PM.png

Aha. <@UJJ1A3G1G> you're right on the money. I didn't know setting a tint would kill all the provided theming.

Yeah though that seems unexpected based on previous behavior with Views?

Or MaterialButton in MDC-Android to be specific?

I'm just using Button from material package in compose.

image.png

Actually looking again at the implementation, I’m not sure this is expected. Like with this snippet, I could see a use case where you want to use a different color besides `contentColor`. Maybe <@UJBKXD0HH> can verify

WAI afaict, but <@UMCJAPF63> (hope I got the right Louis there!) would be able to say definitively

Yeah this is WAI, the button is disabled, so its content should appear visually disabled too :slightly_smiling_face: You can manually set the color if you don’t want this to be the case

<@UMCJAPF63> set a profile pic or a [G] in your profile "full name" or something :stuck_out_tongue:

So maybe a silly question, <@UMCJAPF63> but we're working on the icon here to be server driven... so we're going to be sending down a black .png of the image (let's say a right facing chevron or something) so we're not going to use Icon I think, but instead use an Image that is a coil image. Do you have any advice on how to get it so the tinting works correctly (i.e. our black icon will show as purple tint when it's enabled, but disabled, it will have that grey state?

Maybe just something like:

```// enabled captured in scope
Button(enabled = enabled, ...) {
    val tint = if (enabled) MaterialTheme.colors.primary else LocalContentColor.current
    val color = tint.copy(alpha = LocalContentAlpha.current)
}```
(You can ignore the alpha if you always want the image to be opaque)

There doesn’t need to be any magic here, `Button` just suggests what the content should be, but if you want it to be different in different states, you already _own_ that state :slightly_smiling_face: