Hi folks, I am not sure who is the right person to consult regarding this. I am playing around with...

# compose

[Utkarsh Tiwari]

Hi folks, I am not sure who is the right person to consult regarding this. I am playing around with the code from the official documentation of ModalBottomSheetLayout and it seems like the scrim to dismiss the modal is being triggered when tapping an area within the sheet. Is this expected behaviour?
Here is my code

scrim bug.mp4

[patrick]

Does that change when you wrap the Buttons of the BottomSheet in a Column with full width?

ie:

sheetContent = {
            Column(modifier=Modifier.fillMaxWidth()) {
                PrimaryButton(
                    text = "Hello",
                    onClick = {

                    }
                )
                PrimaryButton(
                    text = "Elon's",
                    onClick = {

                    }
                )
                PrimaryButton(
                    text = "World",
                    onClick = {

                    }
                )
            }
        }

[Utkarsh Tiwari]

Same behaviour with this code.

[patrick]

Looks like the tap is still passed on to the scrim, I guess an empty clickable modifier on the column would “fix” it 😞

[Utkarsh Tiwari]

@patrick You are right. Adding clickable “fixes” the problems.

[Utkarsh Tiwari]

I have filed a bug in case anyone is interested in following: https://issuetracker.google.com/issues/182193069

[jossiwolf]

Compared to BottomDrawer, ModalBottomSheetLayout doesn't block clicks (not sure if there's a spec for that somewhere...), but I think @matvei and I recently talked about that it'd make sense to unify that behavior🤔 Matvei, I'd be happy to create a CL for this if you agree that this change makes sense

[jossiwolf]

(So yeah, not a bug per se, more intended behavior I think, but there are probably more arguments for blocking clicks than not)

[matvei]

We need to clock clicks, it's easier to opt in (also rarely needed) than to opt out. We just fixed it for a stable ModalDrawer, but we need to fix it for ModalBottomSheetLayout and others (Backdrop potentially, etc).

[matvei]

Thanks for filing a bug