I’m seeing some weirdness on beta-01 as I’m trying...
# composev
Vinay Gaba
03/03/2021, 5:35 AMI’m seeing some weirdness on beta-01 as I’m trying to upgrade my library. I’ve zeroed down the issue to the use of a
TextFieldtitleTopAppBarTextFieldTextVinay Gaba
03/03/2021, 5:36 AMNotice how the title on the third screen disappeared and when I clicked on the search icon, the edit text did not appear. Even though it actually allowed me to type in that invisible edit text. I could not see any characters that were being input either.
Vinay Gaba
03/03/2021, 5:37 AMHere is the code for it - https://github.com/airbnb/Showkase/blob/master/showkase/src/main/java/com/airbnb/android/showkase/ui/ShowkaseBrowserApp.kt#L79
You should be able to easily trace the composables as its in the same file
Vinay Gaba
03/03/2021, 5:37 AMIf it helps, here is the branch where I was upgrading it to beta - https://github.com/airbnb/Showkase/pull/130
e
eygraber
03/04/2021, 1:52 AMIs
ShowkaseSearchFieldelsev
Vinay Gaba
03/04/2021, 2:23 AMFair question. I’ve actually confirmed that this is not what is causing it. If you look at the gif, you will notice that they keyboard actually comes up after I click on the search icon. That’s because the edit text has focus, even though I can’t see it. It also allows me to type and my state is updated with that value (however I can’t see what I typed). That’s why I see that filtering on the list is also working.
Something tells me it might be some elevation/clipping weirdness that is hiding my edit text. However the more weird part is that I start seeing it once I minimize my app and open it back.
t
Tash
03/04/2021, 9:54 AMTried to pull the code and run it, seeing the a similar issue but in my case the title never changes from
ComponentsTopAppBartitleShowkaseSearchFieldTash
03/04/2021, 9:55 AMThere is the other variant of
TopAppBarcontentv
Vinay Gaba
03/04/2021, 8:27 PM@Tash Thank you so much for jumping on this and taking a look 🙏🏼 My first reaction was that its probably related to an issue where the state isn’t being propagated - https://kotlinlang.slack.com/archives/CJLTWPH7S/p1614563750245900
Since then I’ve spent some time to verify that the state is actually being updated correctly. I think this might be a TopAppBar/TextField issue. I’m going to try using the alternate component but my guess is that it might have the same issue since all these variants call each other internally 😄
t
Tash
03/04/2021, 8:30 PMNo problem. Oh yeah, if they call each other internally, it could present the same problem 🤦🏼. I don’t mind debugging more later today if you don’t happen to find the root cause by then.
v
Vinay Gaba
03/04/2021, 10:26 PMThanks! you are the best 😄
🙈 1
Vinay Gaba
03/05/2021, 7:01 AMSo I copy pasted the code from the top app bar and started commenting out parts to figure out what’s causing the issue. I can conclusive say that the
SurfaceTopAppBarTopAppBart
Tash
03/05/2021, 10:22 AMInteresting, I wonder how
SurfaceTopAppBarTopAppBarmutableStateOfv
Vinay Gaba
03/05/2021, 4:36 PMWow, I actually did try the
contentt
Tash
03/05/2021, 5:43 PMYeah its really strange that THAT sequence of compositions make it “work”. Another option is, I think you can just replace the entire
TopAppBarisSearchActive == truev
Vinay Gaba
03/05/2021, 6:00 PMI ended up just using a simple Row with some styles to make it look like an AppBar and that got the job done - https://github.com/airbnb/Showkase/pull/130/files#diff-b30e56106f28f96c55285c2222abafe8741686b67e5e1de440160e5b6aa7a302R84
t
Tash
03/06/2021, 6:40 AMNice, that should work! Wonder if its worth filing an issue for
TopAppBarv
Vinay Gaba
03/06/2021, 6:45 AM💯 Was planning on trying to repro it over the weekend and filing an issue
🙏🏼 1
2 Views