Guys I have completed the #AndroidDevChallenge. I ...
# compose
s
Guys I have completed the #AndroidDevChallenge. I hope it helps someone who's looking forward for some UI inspiration with JP Compose implementation. You can download app from Github share your reviews 🙏... Heartly congratulations for Jetpack Compose Team & Android Community who worked hard to make Compose great ♥️ Github
😍 18
👍 14
j
Good work
s
Thanks buddy @joakim
j
Hey, do you know why the dark and light images are not in the same position? When I change the print images forward and back in slack I kinda see the images moving a bit…
I took a look at the code and it seems really nice. I noticed that you could reduce some repeated code.., like
Copy code
if (name == "Male") {
        ChipView(gender = name, colorResource = colorResource(id = R.color.blue))
    } else {
        ChipView(gender = name, colorResource = colorResource(id = R.color.red))
    }
it could be
Copy code
val color = if (name == "Male") {
        R.color.blue
    } else {
        R.color.red
    }
ChipView(gender = name, colorResource = colorResource(id = color))
s
Thanks mate will update this
🎉 1
s
@Spikey Sanju Great work!, I tried your app on slightly older phone, but there were some serious performance issue but i think it's not your fault, I found most of compose app have same issue on this device.
@Spikey Sanju I tried your app on Motorola Moto G4
s
Oh I see. Lemme check this with some older mobiles. Thanks mate
👍 2
c
The android team has requested to file bugs for repros of poor perf. Maybe you can submit this?! Good work @Spikey Sanju
✔️ 1
1
t
Wow, very beautiful UI!
s
Thanks, buddy @therealbluepandabear