Hi guys, Currently i'm developing one sample app. Whenever I click on icon button I need to change t...

# compose

[Spikey Sanju]

Hi guys, Currently i'm developing one sample app. Whenever I click on icon button I need to change the app theme & Icon.

Below code works fine. But is there any way to optimise the below code?... Since I'm repeating the entire code block in both if and else block?

[jaqxues]

val icon = if (isSytemInDarkTheme) painterResource(...) else painterResource(...)

Icon(painter = icon, ...)

[jim]

@Composable
fun WigglesThemeSwitch(onToggle: ()->Unit) {
	Icon(
		Painter = painterResource(if(isSysteminDarkTheme()) R.drawable.ic_light_off else R.drawable.ic_light_on)
		contentDescription = null,
		modifier = Modifier.size(24.dp, 24.dp).clickable { onToggle() })
	)
}

[Spikey Sanju]

Thanks guys it works ♥️

[jaqxues]

Do you know if wrapping lambdas in lambdas decreases performance? I always wondered

So instead of .clickable { onToggle() }

.clickable(action = onToggle)

[jaqxues]

Intuitively I would say the 2nd option would yield better performance, but I am not sure if Kotlin optimizes this automatically

[jim]

I think kotlin team generally recommends the second option when possible, yes.

[jim]

(even if for no other reason than aesthetics)

[Spikey Sanju]

2nd approach it's not working for me... Am I doing anything wrong here 😬

[Spikey Sanju]

It works thanks

[alorma]

There's also a way to change between light / dark on all app