class MyActivity: AppCompatActivity() {
    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)

        setContent {
            val navController = rememberNavController()
            NavHost(navController, startDestination = "") {
                composable("") { TestCompose() }
                composable("test") { TestCompose() }
            }
        }
    }
}

@Composable
fun TestCompose(vm: TestViewModel = viewModel()) {

}

Reading about the API viewModel it seems like using it in the manor I am, it's lifecycle gets attached to

MyActivity

and thus if I navigate multiple

TestCompose

views it will leak my ViewModel

If you inject the view model to the activity and pass it down the composables tree as a paramater the VM would be scoped to the main activity and would not leak from there, if you wish to have a VM for each composable you would need as of (DEC 2020) to wrap each screen with a fragment and scope the vm to the fragment.

So what I'm doing would leak the VM?

Yes, VM, at least the android one, is scoped to a lifecycle owner, a composable is not a lifecycleowner so it would look like you are making multiple VM all scoped to main activity.

@Adam Powell I can't find this issue in the Android bug tracker. I'm guessing its not a high priority, but it seems like something will need to be fixed in the long term. I'm wondering if you think I should open up an issue for it? Thank you

Feel free, file it to the navigation component. If there is one already it'll be duped against it

Navigation already scopes your ViewModels to that

composable

destination, not your activity, so that code is fine

Oh!