What happened to Modifier.weight in alpha04

# compose

[Guy Bieber]

What happened to Modifier.weight in alpha04

[Rudolf Tammekivi]

https://android-review.googlesource.com/c/platform/frameworks/support/+/1420054

[Rudolf Tammekivi]

with(ColumnScope) { Modifier.weight(1f) }

[Guy Bieber]

well that touches a lot of code

[Rudolf Tammekivi]

I guess if you change composable function to be ColumnScope.MyButton then you get it automatically. Also if you use it in Column composable for example.

[Zach Klippenstein (he/him) [MOD]]

I think that’s the point. Modifier.weight doesn’t have any effect outside of `Column`/`Row` composables, so this change is probably intended to help prevent using it where it’s pointless.

[Zach Klippenstein (he/him) [MOD]]

Or just change your child composables to take Modifier parameters, and pass the weight modifier in from wherever the `Column`/`Row` is.

[Guy Bieber]

The problem is inside a Column you still have to do a with statement. It makes the code longer needlessly.

[Guy Bieber]

This works:

Column(with(ColumnScope) {Modifier.weight(.15f) }) {}

This does not:

Column(Modifier.weight(.15f)) {}

[Guy Bieber]

Why inside a column would I need to declare this?

[Guy Bieber]

Just a lot of busy work.

[Guy Bieber]

If I add scope to the functions is the easiest way to clean it up. Probably a smart thing to do.

[Zach Klippenstein (he/him) [MOD]]

Column(with(ColumnScope) {Modifier.weight(.15f) }) {}

Here the weight modifier only does something if the parent of this Column is also a column or row. It doesn’t matter which composable you apply the modifier too, it matters what its parent is.

[Zach Klippenstein (he/him) [MOD]]

e.g. This gives you two columns, side-by-side, which each take up half the width:

Row {
  Column(Modifier.weight(.5f)) { … }
  Column(Modifier.weight(.5f)) { … }
}

This gives you two columns which are stacked on top of each other, with whatever size they want to be (that is, the weight modifier has no effect:

Box {
  Column(with(ColumnScope) { Modifier.weight(.5f) }) { … }
  Column(with(RowScope) { Modifier.weight(.5f) }) { … }
}