I've taken SwipeToRefresh implementation from JetNews into my own project. However, I feel like ther...

# compose

[Halil Ozercan]

I've taken SwipeToRefresh implementation from JetNews into my own project. However, I feel like there is an important bug in the implementation that comes to surface when the state of the UI directly starts in refreshing (loading) status.

refreshingState: Boolean,

is an argument to the SwipeToRefresh composable. It makes total sense that refreshing status is controlled by the parent. However, inner swipe state and this received state of refresh are combined together to call onRefresh callback inside the listener for swipe state change as follows:

val state = rememberSwipeableState(refreshingState) { newValue ->
        // compare both copies of the swipe state before calling onRefresh(). This is a workaround.
        if (newValue && !refreshingState) onRefresh()
        true
    }

However, something goes wrong in this lambda. Even if the refreshingState is changed from true to false by the parent, this lambda will keep reading it as the first time remember is called. If refreshingState was true at the start, it will remain true in the scope of this lambda until composition of SwipeRefreshLayout leaves the UI. As a workaround, I've changed refreshingState to a lambda that returns a boolean.

[Adam Powell]

If you've tried this on alpha03 and still see it, please file an issue for it

[Halil Ozercan]

initially experienced this issue on alpha03. Going to file an issue asap

[Arkadii Ivanov]

Same for me. @Halil Ozercan could you please post the workaround snippet?

[Halil Ozercan]

@Arkadii Ivanov It's been so long I don't even remember in which project I had this issue. I vaguely remember that hoisting boolean state caused this problem. Now there is rememberUpdatedState which might be helpful.