https://kotlinlang.org logo
#compose
Title
# compose
m

manueldidonna

09/07/2020, 9:35 PM
BottomNavivation
composable (green accent) has a different ripple than
BottomNavigationView
(red accent) from Material Components for Android (which is the same effect showed in the material guidelines)
l

Louis Pullen-Freilich [G]

09/07/2020, 11:54 PM
By 'different' do you mean the color of the ripple? Or the shape of the ripple? In either case I believe the Compose implementation is correct and up to date with the latest Material specs, and the
BottomNavigationView
implementation is out of date / incorrect here
m

manueldidonna

09/08/2020, 12:02 AM
Both the shape and the color. Anyway I think this is something that should be easily customizable. On Android a lot of apps (google apps like YouTube, Photos, Maps, Drive) use an unbounded colored ripple for the bottom navigation
l

Louis Pullen-Freilich [G]

09/08/2020, 1:18 AM
Oh sorry, I just realized I was looking at the wrong screenshots - the red one looks correct / how this should behave. Would you mind filing a bug here? The
selectedContentColor
parameter should also be used for the ripple color here. And the bounded ripple looks like a refactoring mistake, it should be changed back to being unbounded 🙂
🎉 1
m

manueldidonna

09/08/2020, 12:14 PM
l

Louis Pullen-Freilich [G]

09/08/2020, 12:17 PM
Thanks!
👍 1