hard to read

# compose

[Siyamed]

hard to read

[Guy Bieber]

less weird

[Siyamed]

does the icon click? or does it immediately act as if textfield was clicked and get into edit mode?

[Siyamed]

i can think that the icon click is handled after the textfield in this example

[Siyamed]

even though i do not know how things are placed and ordered

[Siyamed]

as far as i know once a click is handled by a handler, it is not delegated to others.

[Siyamed]

cc @Alexandre Elias [G]

[Guy Bieber]

It acts like a textfield immediately. I don’t see a shadow on the icon when pressed.

[Siyamed]

then textifeld gets the click

[Siyamed]

the remaining of the code would be useful

[Siyamed]

TextfieldWithHint composable

[Guy Bieber]

@Composable
    fun TextFieldWithHint(
        text: String,
        hint: @Composable() () -> Unit,
        onDone: (String) -> Unit = {},
        backgroundColor: Color = nikolaColors.color19,
        textColor : Color = nikolaColors.White,
        fontSize : TextUnit =  18.sp,
        trailingIcon: @Composable (() -> Unit)? = null,
        keyboardType: KeyboardType = KeyboardType.Text,
        visualTransformation: VisualTransformation =  VisualTransformation.None,
        cursorColor : Color = nikolaColors.White
    ) {

        val mText =
            savedInstanceState(saver = TextFieldValue.Saver) { TextFieldValue(text) }


        OutlinedTextField(
            value = mText.value,
            label = hint,
            textStyle = TextStyle (
                color = textColor,
                fontSize = fontSize
            ),
            keyboardType = keyboardType,
            imeAction = ImeAction.Done,
            trailingIcon = trailingIcon,
            onValueChange = {
                mText.value = it
            },
            onImeActionPerformed = { action, softKeyboard ->
                if (action == ImeAction.Done) {
                    //todo remove hack when android fixes it
                    //On older phones the shift key shows up as 00 in the string
                    val char : Char = 0x00.toChar()
                    var str = mText.value.text.replace("${char}", "")
                    onDone(str) 
                    hideKeyboard()
                }
            },
            activeColor = cursorColor,
            visualTransformation = visualTransformation
        )
    }

[Guy Bieber]

I bet the if statement isn’t reevaluated for the visualTransformation .

[Siyamed]

thank you I see it now. checked the code a bit. this sounds like a bug

[Siyamed]

trailing icon is defined before textfield in the code

[Siyamed]

I wonder if it is what causes the trailing not to be able to get the click

[Siyamed]

https://cs.android.com/androidx/platform/frameworks/support/+/androidx-master-dev:compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt;l=346?q=OutlinedTextField

[Siyamed]

Can you please create a ticket about this?

[Guy Bieber]

Question: does it evaluate in order of definition. If so the trailing icon should have got the click.

[Guy Bieber]

@Siyamed The issue tracker (https://issuetracker.google.com/issues?q=componentid:612128) does not allow me to create an issue (create button is grey).

[Guy Bieber]

This works in alpha-02