https://kotlinlang.org logo
#compose
Title
# compose
s

Siyamed

07/31/2020, 4:47 PM
So leaning to yes for your question :)
m

matvei

07/31/2020, 4:48 PM
Converting this to a thread 🙂 Yeah, what Siyamed said basically
But if people will find usefull to have separate Core and Base textfield apis -- we can leave them. But for now my desire is to merge Base and Core testfields and make CoreTextfield offer custom cursor drawing with some reasonable default from BaseTextField
Because now
BaseTextField
=
CoreTextField
+ private
cursorModifier
And it's not a big reason to keep one separate APIs, imo 🙂
s

Siyamed

07/31/2020, 4:50 PM
(maybe + some theming, not sure about it right now)
m

matvei

07/31/2020, 4:51 PM
Oh right, thanks Siyamed. Also BaseTextField sets text color to
contentColor
, if provided by the parent
z

Zach Klippenstein (he/him) [MOD]

07/31/2020, 4:54 PM
So if one were building custom components for a custom design system, they would probably still use
BaseTextField
? Unless the design system required something extreme like non-standard cursors, which is probably unlikely.
s

Siyamed

07/31/2020, 4:54 PM
Yes
👍 2
m

matvei

07/31/2020, 4:54 PM
I have WIP CL where I was experimenting with this idea: https://android-review.googlesource.com/c/platform/frameworks/support/+/1372123 It's waaay far off from landing, if at all
👍 1