<@UQ0U88BU6> <https://github.com/zsoltk/compose-router/pull/35> Any chance you can explain how I can...

# compose

[Madhava]

@Zsolt https://github.com/zsoltk/compose-router/pull/35 Any chance you can explain how I can fix the unchecked cast warnings for my PR on compose-router?

[Leland Richardson [G]]

hmm.

Just tried what i think is equivalent locally and didn’t have any issues

[Leland Richardson [G]]

well, it depends what you’re asking about i guess

[Leland Richardson [G]]

private val backStackMap: MutableMap<Any, BackStack<*>> =
    mutableMapOf()

class BackStack<T>(initialElement: T)

@Composable
private fun <T> fetchBackStack(key: String, defaultElement: T, override: T?): BackStack<T> {
    // line A
    val existing = backStackMap[key] as BackStack<T>?
    return when {
        // line B
        override != null -> BackStack(override)
        existing != null -> existing
        else -> BackStack(defaultElement)
    }.also {
        backStackMap[key] = it
    }
}

[Leland Richardson [G]]

line B should not need any cast

[Leland Richardson [G]]

line A does

[Leland Richardson [G]]

you don’t have any way of getting around the cast in line A unless you construct the map in such a way that the key itself indicates the element type, but you’d have to change the API of fetchBackStack in order to do that

[Madhava]

[Madhava]

When I substitute with the code you have above i still get the same error about BackStack<out T>

[Madhava]

I am happy to make any changes you think are needed to get this PR merged as I am using the router in an app which I want to update to dev15. 🙂 https://github.com/zsoltk/compose-router/pull/35

[Madhava]

I have updated the PR with your suggestions, still 2 open ones I am unsure what to do about:
https://github.com/zsoltk/compose-router/pull/35