< Zach Klippenstein he him MOD > I tried to get your compose kotlinlang #compose

@Zach Klippenstein (he/him) [MOD] I tried to get your compose-backstack to work with dev14 but there are some changes I don't understand: https://github.com/madhavajay/compose-backstack/commit/bfbb56643a514b6943554ef306cb1c14b4b25791 Any chance you could help me understand what I need to fix to get this working and PR?

The main things are: • @Model • @Pivotal • PercentageLayoutOffset The code compiles and the sample app loads but it seems like a few things are broken still.

Zach Klippenstein (he/him) [MOD]

07/14/2020, 1:32 AM

@Pivotal

needs to be replaced with

key

@Model

needs to be replaced by `MutableState`s. I need to tidy a few other things up too and do a release, gimme a few hours

Madhava

07/14/2020, 1:50 AM

Oh okay, i can wait for your release if you prefer, no rush. Yeah i saw mention of key in the release notes but not what "key" is.

Let me know if theres anything I can do to help. 🙂

Zach Klippenstein (he/him) [MOD]

07/14/2020, 1:54 AM

Thanks for putting up the commit!

Madhava

07/14/2020, 2:02 AM

For some reason Android Studio could not fix the gradle dependencies automatically, so that was actually the hardest part, figuring out why and manually updating them.

Zach Klippenstein (he/him) [MOD]

07/14/2020, 2:51 AM

PercentageLayoutModifier

needed some surgery too, since

LayoutModifier

changed.

almost got the tests passing again for dev13

👍 1

Madhava

07/14/2020, 3:00 AM

yeah i thought it might have been a better idea to do the upgrades 1 at a time so its easier to see the "upgrade advice"

Zach Klippenstein (he/him) [MOD]

07/14/2020, 3:20 AM

https://github.com/zach-klippenstein/compose-backstack/pull/31

👍 1

Madhava

07/14/2020, 3:28 AM

awesome!

Zach Klippenstein (he/him) [MOD]

07/14/2020, 4:38 AM

v0.4.0 is out, should sync to maven central within the hour: https://github.com/zach-klippenstein/compose-backstack/releases/tag/0.4.0

👍 1

Madhava

07/14/2020, 6:12 AM

Demo is working great thanks! 🙂

🙌 1

Zach Klippenstein (he/him) [MOD]

07/14/2020, 1:27 PM

Would love feedback on the API if you have any thoughts, and feel free to file bugs

3 Views