https://kotlinlang.org logo
Join Slack
Powered by
<@U0KMMQA20> I tried to get your compose-backstack...
# compose
m
@Zach Klippenstein (he/him) [MOD] I tried to get your compose-backstack to work with dev14 but there are some changes I don't understand: https://github.com/madhavajay/compose-backstack/commit/bfbb56643a514b6943554ef306cb1c14b4b25791 Any chance you could help me understand what I need to fix to get this working and PR?
The main things are: • @Model • @Pivotal • PercentageLayoutOffset The code compiles and the sample app loads but it seems like a few things are broken still.
z
@Pivotal
needs to be replaced with 
key
@Model
needs to be replaced by `MutableState`s. I need to tidy a few other things up too and do a release, gimme a few hours
m
Oh okay, i can wait for your release if you prefer, no rush. Yeah i saw mention of key in the release notes but not what "key" is.
Let me know if theres anything I can do to help. 🙂
z
Thanks for putting up the commit!
m
For some reason Android Studio could not fix the gradle dependencies automatically, so that was actually the hardest part, figuring out why and manually updating them.
z
PercentageLayoutModifier
needed some surgery too, since 
LayoutModifier
changed.
almost got the tests passing again for dev13
👍 1
m
yeah i thought it might have been a better idea to do the upgrades 1 at a time so its easier to see the "upgrade advice"
z
m
awesome!
z
v0.4.0 is out, should sync to maven central within the hour: https://github.com/zach-klippenstein/compose-backstack/releases/tag/0.4.0
👍 1
m
Demo is working great thanks! 🙂
🙌 1
z
Would love feedback on the API if you have any thoughts, and feel free to file bugs
3 Views
Open in Slack
PreviousNext
Powered by