https://kotlinlang.org logo
#compose
Title
# compose
m

Madhava

07/06/2020, 1:01 AM
Does anyone know if the MaterialTheme or Ripple effects can be disabled. They seem to be quite laggy on the current versions and I was wondering if they can simply be turned off to improve performance?
r

romainguy

07/06/2020, 2:14 AM
If there are performance issues it would be best to fix it instead of disabling the feature. On what version of compose and which device(s) do you observe this issue?
a

Adam Powell

07/06/2020, 2:24 AM
I'll venture a guess that this is more about the ripple effect stalling behind large recompositions in a frame since it's animating on the main thread along with those recompositions at the moment
👆 1
m

Madhava

07/06/2020, 3:27 AM
Iv been using multiple versions since dev09, latest is dev14, my device is an LG G6 on Android 8
The emulator is similar. I notice when I tap on any element the ripple is really slow
r

romainguy

07/06/2020, 3:28 AM
Slow or skipping frames?
m

Madhava

07/06/2020, 3:28 AM
My next step was to do some frame debugging, whats the best way to do that in the latest canary's?
Copy code
2020-07-06 13:40:14.351 15051-15051/app I/Choreographer: Skipped 50 frames!  The application may be doing too much work on its main thread.
2020-07-06 13:40:34.613 15051-15051/app I/Choreographer: Skipped 39 frames!  The application may be doing too much work on its main thread.
but not every time i tap
I cant seem to get it to say skipped frames anymore if i just keep tapping the checkboxes or buttons
Copy code
2020-07-06 13:41:48.228 15051-15051/app I/ViewRootImpl: ViewRoot's Touch Event : ACTION_DOWN
2020-07-06 13:41:48.383 15051-15051/app I/ViewRootImpl: ViewRoot's Touch Event : ACTION_UP
2020-07-06 13:41:49.048 15051-15076/app I/zygote64: Compiler allocated 6MB to compile void android.view.ViewRootImpl.performTraversals()
2020-07-06 13:41:54.839 15051-15051/app I/ViewRootImpl: ViewRoot's Touch Event : ACTION_DOWN
2020-07-06 13:41:54.974 15051-15051/app I/ViewRootImpl: ViewRoot's Touch Event : ACTION_UP
2020-07-06 13:41:56.966 15051-15051/app I/ViewRootImpl: ViewRoot's Touch Event : ACTION_DOWN
2020-07-06 13:41:57.093 15051-15051/app I/ViewRootImpl: ViewRoot's Touch Event : ACTION_UP
2020-07-06 13:41:58.031 15051-15051/app I/ViewRootImpl: ViewRoot's Touch Event : ACTION_DOWN
2020-07-06 13:41:58.194 15051-15051/app I/ViewRootImpl: ViewRoot's Touch Event : ACTION_UP
2020-07-06 13:42:08.517 15051-15051/app I/ViewRootImpl: ViewRoot's Touch Event : ACTION_DOWN
2020-07-06 13:42:08.551 15051-15076/app I/zygote64: Do full code cache collection, code=498KB, data=352KB
2020-07-06 13:42:08.554 15051-15076/app I/zygote64: After code cache collection, code=350KB, data=226KB
2020-07-06 13:42:08.654 15051-15051/app I/ViewRootImpl: ViewRoot's Touch Event : ACTION_UP
so i guess its going to 50% CPU after i tap
does that mean the render threads are taking 600ms to complete?
5 Views