TextField with a Keyboard password doesn t work as expected

Question

TextField with a Keyboard password doesn t work as expected to hide the password as it is typed Is there something like this for text fields ``` by default edittext setTransformationMethod new PasswordTransformationMethod You can make it custom edittext setTransformationMethod new AsterPasswordTransformationMethod ```

Vinay Gaba · Answer

I have an example of this here <https github com vinaygaba Learn Jetpack Compose By Example blob a7cba8e6d3c43b288e539323ba6d1ba92c408814 app src main java com example jetpackcompose text TextFieldActivity kt L252>

Leland Richardson [G] · Answer

cc < Siyamed> should this be easier perhaps `visualTransformation` should have a default value that is a function of the keyboardType

Siyamed · Answer

I dont think it would scale

Siyamed · Answer

The difference of how the outout will look like what characters keyboard will show is it a number password ascii password what the action would be visible password invisible password etc it far too complex

Siyamed · Answer

Things get too complicated too fast there and we end up in a state where we cant support the need

Siyamed · Answer

I am assuming that this is not about the api of visual transformation which i find hard to use but it is about having to add a visual transformation

Leland Richardson [G] · Answer

yeah

Leland Richardson [G] · Answer

you might be totally right but i m not sure i see the issue

Siyamed · Answer

Hmm even though keyboard type is password the visual outout might be hidden

Leland Richardson [G] · Answer

is visual output different from visualTransformation

Siyamed · Answer

Or keyboard type is numeric but not password but still output visuals is password

Siyamed · Answer

Too many combinations

Siyamed · Answer

Will think how it can be better but adding signal to keyboard type wouldn t scale

Leland Richardson [G] · Answer

i guess it seems like not a scalability issue to me it s taking advantage of the default value so you can add as few common cases as you want

Leland Richardson [G] · Answer

in this case we have the current common cases = 1

Leland Richardson [G] · Answer

and only increasing to 2

Leland Richardson [G] · Answer

no need to increase it further

Siyamed · Answer

I dont agree with common cases especially when it is about text based on my experience

Leland Richardson [G] · Answer

people could still specify any visual tranformation they wanted

Siyamed · Answer

I will check it

Leland Richardson [G] · Answer

not trying to be pushy here just trying to understand the scalability argument

Siyamed · Answer

I also dont understand the issue what is hard to say visual transformatuon is password transformation

Siyamed · Answer

Keyboard type is specific to keyboard not textfield

Leland Richardson [G] · Answer

it doesn t seem terribly difficult or anything

Siyamed · Answer

It is possible that when we see that keyboard type is passowrd and visualtranformation is not defined we attach one

Leland Richardson [G] · Answer

that was what i was suggesting

Siyamed · Answer

Sorry i double checjed after i wrote i though you wanted a visual transformation api in keyboard type class

Siyamed · Answer

Makes sense

Siyamed · Answer

534pm effect

Leland Richardson [G] · Answer

i was thinking something like ```visualTransformation VisualTransformation = VisualTransformation None``` changed to ```visualTransformation VisualTransformation = if keyboardType == KeyboardType Password PasswordVisualTransformation else VisualTransformation None```

Siyamed · Answer

Makes sense

Leland Richardson [G] · Answer

it just makes a common case a little easier to get to

Leland Richardson [G] · Answer

but i don t feel strongly slightly smiling face

Siyamed · Answer

We should guide community about the difference of keyboardtype vs visuals very well though

Siyamed · Answer

Sounds good

Leland Richardson [G] · Answer

thumbsup also thinking more about this i can see the argument of trying to keep these separate I was just thinking that it would be nice to have a common case password textfield be only one additional line of code

Leland Richardson [G] · Answer

i also wish it was easier to not allocate a new PasswordVisualTransformation on each recompose if you pass it in

Leland Richardson [G] · Answer

wonder if a `VisualTransformation Password` makes sense

Leland Richardson [G] · Answer

assuming its stateless which i m guessing it is

Siyamed · Answer

That also makes sense

Siyamed · Answer

It is something very common Password one itself does not have a state

Siyamed · Answer

Ok so i create two tickets

Guy Bieber · Answer

Smile Didn t want to spawn a huge debate Got it working with the API the way it is

Guy Bieber · Answer

all good

Guy Bieber · Answer

```ui TextFieldStyled text = appModel session user userPass onDone = appModel session user userPass = it keyboardType = KeyboardType Password visualTransformation = PasswordVisualTransformation ```

Siyamed · Answer

158247724 for default transformation

Siyamed · Answer

face palm

Siyamed · Answer