For the new `StateFlow<T>.collectAsFlow()` e...

# compose

[Zach Klippenstein (he/him) [MOD]]

For the new StateFlow<T>.collectAsFlow() extension introduced in dev12 (https://android-review.googlesource.com/c/platform/frameworks/support/+/1308154), why does T have a non-null upper bound? `StateFlow`’s T is nullable, and I don’t see why this bound should be required for the extension.

[Zach Klippenstein (he/him) [MOD]]

The definition of the function in question is:

inline fun <T : Any> StateFlow<T>.collectAsState(
    context: CoroutineContext = Dispatchers.Main
): State<T> = collectAsState(value, context)

[Leland Richardson [G]]

Looks like a mistake to me

[Zach Klippenstein (he/him) [MOD]]

👍 I'll file a bug

[jw]

Send the fix yourself! It's easier than you think!

[jw]

You can have the codebase open in an IDE in 4 commands: brew install repo, make and cd into a directory, repo init ... (steal from readme), repo sync -j16, ./studiow 💥 !

[jw]

Actually for compose you need to do ./ui/studiow I think

[Andrey Kulikov]

indeed, it should be just <T>, thanks for noticing. did you file a bug?

[Andrey Kulikov]

or yes, feel free to contribute the fix!

[Zach Klippenstein (he/him) [MOD]]

I filed https://issuetracker.google.com/issues/157674865 and I am working on submitting a fix, but having trouble getting AS to sync and see the test code as code.

[Zach Klippenstein (he/him) [MOD]]

How do I generate a Change-Id for the commit?

[Andrey Kulikov]

there is a precommit hook which will add it for you

[jw]

First one is the hardest. Make sure you use your work email as the git author we have an company-wide CLA in place. You might need added to a google group internally though....

[Zach Klippenstein (he/him) [MOD]]

I’m getting this error when running `repo upload …`:

[FAILED] commit_msg_changeid_field
    Commit message is missing a "Change-Id:" line.  It must match the
    following case-sensitive regex:

        ^Change-Id: I[a-f0-9]+$